Review main Merged

70492[BUGFIX] Allow shortcuts to pages with doktype > 200

Marvin Dosse CR +2 V +2 Easy +7 −1 updated 09/02/21, 14:56

Commit message

Pages with doktype > 200 had not been considered in the sql query.
Now all doktypes are being fetched except for the spacer,
sysfolder and recycler.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Marvin Dosse +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benni Mack +2
    • Marvin Dosse +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. Marvin Dosse uploaded patch set 1 08/12/21, 14:07

  2. core-ci voted on patch set 1 V +1 08/12/21, 14:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14751

  3. Mathias Brodala commented on patch set 1 CR -1 08/13/21, 06:56

    PageRepository.php:978

    This can be merged. Also we can make this slighly more readable by using an array and doing an implode() before injecting this into this SQL snippet. It's bad enough already that we work with SQL fragments here so we should at least try to make the code as compact and readable as possible. :-)
  4. Jens Pausewang uploaded patch set 2 08/13/21, 08:54

  5. Jens Pausewang commented on patch set 2 08/13/21, 08:59

    PageRepository.php:978 Reply

    Good idea, I adjusted the patch accordingly, it is more readable now 👍
  6. Mathias Brodala commented on patch set 2 08/13/21, 09:02

    PageRepository.php:983

    Please add this to the list above.
  7. Jens Pausewang uploaded patch set 3 08/13/21, 09:11

  8. Jens Pausewang commented on patch set 3 08/13/21, 09:12

    PageRepository.php:983 Reply

    Done
  9. core-ci voted on patch set 2 V +1 08/13/21, 09:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14898

  10. Mathias Brodala voted on patch set 3 CR +1 08/13/21, 09:19

  11. Marvin Dosse voted on patch set 3 CR +1 08/13/21, 09:21

  12. Marvin Dosse voted on patch set 3 V +1 08/13/21, 09:23

  13. core-ci voted on patch set 3 V +1 08/13/21, 09:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14908

  14. Benni Mack voted on patch set 3 V +2 CR +2 09/02/21, 14:56

  15. Benni Mack merged patch set 4 09/02/21, 14:56