Review main Merged

70496[DOCS] Document usage of YAML loader

Björn Jacob CR +2 V +2 Normal +49 −10 updated 08/12/21, 17:55

Commit message

The Form Framework ships its own YAML loader and
does not consistently use the YAML loader of the
TYPO3 core. The patch documents the reasons and
shows when which loader is used. Additionally,
some inconsistencies are fixed with this patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 57

  1. Björn Jacob uploaded patch set 1 08/12/21, 14:32

  2. core-ci voted on patch set 1 V +1 08/12/21, 14:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14762

  3. Lina Wolf uploaded patch set 2 08/12/21, 17:34

  4. Lina Wolf commented on patch set 2 V +1 CR +1 08/12/21, 17:36

    I build the documentation, it builds without sphinx errors now. The result looks fine.
  5. core-ci voted on patch set 2 V +1 08/12/21, 17:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14814

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 08/12/21, 17:55

  7. Christian Kuhn merged patch set 3 08/12/21, 17:55