Review main Merged

70497[TASK] gitlab-ci: Backup TYPO3 logs of backend acceptance tests

Alexander Nitsche CR +2 V +2 Easy +8 −0 updated 08/12/21, 15:47

Commit message

Sometimes acceptance tests fail due to a failed TYPO3 backend request,
which is recorded in the TYPO3 log file. Save this log file along with
the Acceptance Reports folder in the gitlab-ci job artifacts.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Alexander Nitsche uploaded patch set 1 08/12/21, 14:41

  2. Wouter Wolters voted on patch set 1 CR +1 08/12/21, 14:43

  3. Alexander Nitsche uploaded patch set 2 08/12/21, 14:54

  4. core-ci voted on patch set 1 V -1 08/12/21, 15:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14764

  5. Alexander Nitsche uploaded patch set 3 08/12/21, 15:07

  6. Alexander Nitsche commented on patch set 3 08/12/21, 15:10

    The failing test run from patch 2 proved that the backup of TYPO3 logs to artifacts works. Restored working version in patch 3. Awaiting green gitlab-ci run again.
  7. core-ci voted on patch set 2 V -1 08/12/21, 15:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14768

  8. core-ci voted on patch set 3 V -1 08/12/21, 15:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14776

  9. core-ci voted on patch set 3 V +1 08/12/21, 15:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14776

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 08/12/21, 15:45

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 08/12/21, 15:47

  12. Christian Kuhn merged patch set 4 08/12/21, 15:47