Review main Merged

70498[BUGFIX] Fix spelling error in form

Björn Jacob CR +2 V +2 Easy +7 −7 updated 08/12/21, 16:06

Commit message

In #90264 the datepicker JS was moved to an external
file. A new YAML configuration has been introduced.
Unfortunately, a nasty spelling error sliped in which
has been fixed now.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1013

  1. Björn Jacob uploaded patch set 1 08/12/21, 14:55

  2. Björn Jacob uploaded patch set 2 08/12/21, 14:56

  3. Oli Bartsch commented on patch set 1 CR -1 08/12/21, 14:57

    DatePickerViewHelper.php:1

    Seems wrong ;)
  4. Christian Kuhn commented on patch set 2 CR -1 08/12/21, 14:57

    DatePickerViewHelper.php:1

    ??
  5. Björn Jacob uploaded patch set 3 08/12/21, 15:00

  6. Björn Jacob commented on patch set 3 08/12/21, 15:01

    Very sry guys. Quite obvious 😊. Fixed it.

    DatePickerViewHelper.php:1 Reply

    Done

    DatePickerViewHelper.php:1 Reply

    Done
  7. core-ci voted on patch set 2 V -1 08/12/21, 15:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14772

  8. core-ci voted on patch set 1 V -1 08/12/21, 15:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14771

  9. core-ci voted on patch set 3 V +1 08/12/21, 15:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14773

  10. Wouter Wolters voted on patch set 3 V +1 CR +1 08/12/21, 15:55

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 08/12/21, 16:00

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 08/12/21, 16:06

  13. Oli Bartsch merged patch set 4 08/12/21, 16:06