70503[TASK] Strictify UnitTests part 1
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Marcin Sągol +1
-
Verified V +2 Done
- Christian Kuhn +2
- Marcin Sągol +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/scheduler/Tests/Unit/CronCommand/AccessibleProxies/NormalizeCommandAccessibleProxy.php+10 −10
- typo3/sysext/scheduler/Tests/Unit/CronCommand/CronCommandTest.php3+17 −17
- typo3/sysext/scheduler/Tests/Unit/CronCommand/NormalizeCommandTest.php3+33 −35
- typo3/sysext/scheduler/Tests/Unit/Task/CachingFrameworkGarbageCollectionTest.php+7 −6
- typo3/sysext/seo/Tests/Unit/HrefLang/HrefLangGeneratorTest.php+4 −12
- typo3/sysext/seo/Tests/Unit/MetaTag/OpenGraphMetaTagManagerTest.php+6 −6
- typo3/sysext/seo/Tests/Unit/MetaTag/TwitterCardMetaTagManagerTest.php+6 −6
- typo3/sysext/seo/Tests/Unit/XmlSitemap/PagesXmlSitemapDataProviderTest.php2+6 −4
- typo3/sysext/setup/Tests/Unit/Controller/SetupModuleControllerTest.php+6 −6
- typo3/sysext/t3editor/Tests/Unit/Registry/AddonRegistryTest.php+2 −6
- typo3/sysext/t3editor/Tests/Unit/Registry/ModeRegistryTest.php+1 −4
- typo3/sysext/workspaces/Tests/Unit/Controller/Remote/RemoteServerTest.php+10 −8
Review log 1519
-
Wouter Wolters uploaded patch set 1 08/12/21, 15:33
-
Oliver Klee voted on patch set 1 CR +1 08/12/21, 15:45
-
core-ci voted on patch set 1 V +1 08/12/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14785
-
Christian Kuhn commented on patch set 1 08/12/21, 16:31
NormalizeCommandTest.php:20anja told me we don't import top level classes but use \Foo instead. -
Wouter Wolters commented on patch set 1 08/12/21, 17:04
CronCommandTest.php:108Replythat will be done separatly and automated 😊NormalizeCommandTest.php:20Replyphpstorm tells me that I can import it and have one less warning. Is this documented somewhere and can this be forced that we don't do allow it this way. If not enforced I opt for leaving it this way. IMO less warnings the better. -
Christian Kuhn commented on patch set 1 08/12/21, 17:08
CronCommandTest.php:108ReplyAckNormalizeCommandTest.php:20Reply Unresolvedunsure if documented elsewhere. afaik we avoided top level class imports in the core: they don't increase readability since it introduces a level of indirection to save a single '\'. -
Wouter Wolters uploaded patch set 2 08/12/21, 17:34
-
Wouter Wolters wrote 08/12/21, 17:41
Topic set to unit-strict -
core-ci voted on patch set 2 V +1 08/12/21, 17:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14813
-
Andreas Kienast voted on patch set 2 V +1 CR +1 08/13/21, 09:41
-
Marcin Sągol commented on patch set 2 08/13/21, 10:53
PagesXmlSitemapDataProviderTest.php:82Can we declare parameter type? -
Wouter Wolters commented on patch set 3 08/13/21, 11:10
Published edit on patch set 2. -
Wouter Wolters commented on patch set 3 08/13/21, 11:10
PagesXmlSitemapDataProviderTest.php:82ReplyDone -
core-ci voted on patch set 3 V -1 08/13/21, 11:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14943
-
core-ci voted on patch set 3 V +1 08/13/21, 11:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14943
-
Marcin Sągol voted on patch set 3 V +1 CR +1 08/13/21, 12:38
-
Oliver Klee voted on patch set 3 CR +1 08/13/21, 12:39
-
Christian Kuhn voted on patch set 3 V +2 CR +2 08/13/21, 21:28
-
Christian Kuhn merged patch set 4 08/13/21, 21:29
CronCommandTest.php:108