Review main Merged

70503[TASK] Strictify UnitTests part 1

Wouter Wolters CR +2 V +2 Normal +108 −120 updated 08/13/21, 21:29

Commit message

The following core extensions are handled:

* EXT:scheduler
* EXT:seo
* EXT:setup
* EXT:t3editor
* EXT:workspaces

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Marcin Sągol +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Marcin Sągol +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 1519

  1. Wouter Wolters uploaded patch set 1 08/12/21, 15:33

  2. Oliver Klee voted on patch set 1 CR +1 08/12/21, 15:45

  3. core-ci voted on patch set 1 V +1 08/12/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14785

  4. Christian Kuhn commented on patch set 1 08/12/21, 16:31

    CronCommandTest.php:108

    guess we could drop those when adding return type restrictions - make the code a bit more dense. this patch / separate patch?

    NormalizeCommandTest.php:20

    anja told me we don't import top level classes but use \Foo instead.
  5. Wouter Wolters commented on patch set 1 08/12/21, 17:04

    CronCommandTest.php:108 Reply

    that will be done separatly and automated 😊

    NormalizeCommandTest.php:20 Reply

    phpstorm tells me that I can import it and have one less warning. Is this documented somewhere and can this be forced that we don't do allow it this way. If not enforced I opt for leaving it this way. IMO less warnings the better.
  6. Christian Kuhn commented on patch set 1 08/12/21, 17:08

    CronCommandTest.php:108 Reply

    Ack

    NormalizeCommandTest.php:20 Reply Unresolved

    unsure if documented elsewhere. afaik we avoided top level class imports in the core: they don't increase readability since it introduces a level of indirection to save a single '\'.
  7. Wouter Wolters uploaded patch set 2 08/12/21, 17:34

  8. Wouter Wolters wrote 08/12/21, 17:41

    Topic set to unit-strict
  9. core-ci voted on patch set 2 V +1 08/12/21, 17:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14813

  10. Andreas Kienast voted on patch set 2 V +1 CR +1 08/13/21, 09:41

  11. Marcin Sągol commented on patch set 2 08/13/21, 10:53

    PagesXmlSitemapDataProviderTest.php:82

    Can we declare parameter type?
  12. Wouter Wolters commented on patch set 3 08/13/21, 11:10

    Published edit on patch set 2.
  13. Wouter Wolters commented on patch set 3 08/13/21, 11:10

    PagesXmlSitemapDataProviderTest.php:82 Reply

    Done
  14. core-ci voted on patch set 3 V -1 08/13/21, 11:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14943

  15. core-ci voted on patch set 3 V +1 08/13/21, 11:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14943

  16. Marcin Sągol voted on patch set 3 V +1 CR +1 08/13/21, 12:38

  17. Oliver Klee voted on patch set 3 CR +1 08/13/21, 12:39

  18. Christian Kuhn voted on patch set 3 V +2 CR +2 08/13/21, 21:28

  19. Christian Kuhn merged patch set 4 08/13/21, 21:29