Review main Merged

70506[TASK] Make unit tests from adminpanel more strict

Roman Büchler CR +2 V +2 Normal +40 −28 updated 08/13/21, 09:45

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1014

  1. Roman Büchler uploaded patch set 1 08/12/21, 15:39

  2. Roman Büchler uploaded patch set 2 08/12/21, 15:56

  3. core-ci voted on patch set 1 V -1 08/12/21, 16:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14789

  4. core-ci voted on patch set 2 V -1 08/12/21, 16:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14799

  5. Christian Kuhn wrote 08/12/21, 17:44

    Topic set to unit-strict
  6. core-ci voted on patch set 2 V +1 08/12/21, 18:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14799

  7. Wouter Wolters uploaded patch set 3 08/12/21, 18:56

  8. Wouter Wolters voted on patch set 3 V +1 CR +1 08/12/21, 18:57

  9. core-ci voted on patch set 3 V +1 08/12/21, 19:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14832

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 08/13/21, 09:41

  11. Andreas Kienast commented on patch set 3 V 0 CR -1 08/13/21, 09:42

    will check something
  12. Andreas Kienast voted on patch set 3 V +2 CR +2 08/13/21, 09:43

  13. Andreas Kienast merged patch set 4 08/13/21, 09:43

  14. Rudy Gnodde voted on patch set 4 CR +1 08/13/21, 09:45