70506[TASK] Make unit tests from adminpanel more strict
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Wouter Wolters +1
- Rudy Gnodde +1
-
Verified V +2 Done
- Andreas Kienast +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/MainModuleFixture.php+1 −1
- typo3/sysext/adminpanel/Tests/Unit/Fixtures/SubModuleFixture.php+3 −3
- typo3/sysext/adminpanel/Tests/Unit/Middleware/AdminPanelInitiatorTest.php+6 −5
- typo3/sysext/adminpanel/Tests/Unit/Modules/PreviewModuleTest.php+8 −6
- typo3/sysext/adminpanel/Tests/Unit/Service/ConfigurationServiceTest.php+11 −8
- typo3/sysext/adminpanel/Tests/Unit/Service/ModuleLoaderTest.php+8 −4
- typo3/sysext/adminpanel/Tests/Unit/Utility/StateUtilityTest.php+3 −1
Review log 1014
-
Roman Büchler uploaded patch set 1 08/12/21, 15:39
-
Roman Büchler uploaded patch set 2 08/12/21, 15:56
-
core-ci voted on patch set 1 V -1 08/12/21, 16:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14789
-
core-ci voted on patch set 2 V -1 08/12/21, 16:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14799
-
Christian Kuhn wrote 08/12/21, 17:44
Topic set to unit-strict -
core-ci voted on patch set 2 V +1 08/12/21, 18:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14799
-
Wouter Wolters uploaded patch set 3 08/12/21, 18:56
-
Wouter Wolters voted on patch set 3 V +1 CR +1 08/12/21, 18:57
-
core-ci voted on patch set 3 V +1 08/12/21, 19:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14832
-
Andreas Kienast voted on patch set 3 V +2 CR +2 08/13/21, 09:41
-
Andreas Kienast commented on patch set 3 V 0 CR -1 08/13/21, 09:42
will check something -
Andreas Kienast voted on patch set 3 V +2 CR +2 08/13/21, 09:43
-
Andreas Kienast merged patch set 4 08/13/21, 09:43
-
Rudy Gnodde voted on patch set 4 CR +1 08/13/21, 09:45