Review 11.3 Merged

70509[TASK] Forward initiator to typo3/html-sanitizer

Oliver Hader CR +2 V +2 Normal +56 −2 updated 08/12/21, 17:57

Commit message

A new `SanitizerInitiator` is added and forwarded to
`typo3/html-sanitizer`. This allows getting a full stack-trace
when HTML nodes have been sanitized/modified and to debug the
actual cause (initiator) much better.

To receive corresponding initiator stack-traces

* logging for TYPO3.HtmlSanitizer namespace needs to be enabled
* TypoScript `config.debug = 1` must be set, or as a fall-back
  `$GLOBALS['TYPO3_CONF_VARS']['FE']['debug'] = true;` must be set
* HTML sanitizer must have found and modified invalid tags/attributes

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Oliver Hader uploaded patch set 1 08/12/21, 16:24

  2. core-ci voted on patch set 1 V +1 08/12/21, 16:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14804

  3. Oliver Hader voted on patch set 1 V +2 CR +2 08/12/21, 17:57

  4. Oliver Hader merged patch set 2 08/12/21, 17:57