Review 10.4 Abandoned

70513[BUGFIX] Ensure uncached forms in case of POST requests

waldhacker CR 0 V 0 Hard +339 −132 updated 11/20/22, 14:46

Commit message

A new `FormRequestHandler` has been introduced as entry point which
takes care of creating and rendering the actual `FormRuntime`.
Independent of the current application dispatcher (either the
default `FormFrontendController`, any custom Extbase controller
or a TypoScript `FLUIDTEMPLATE` cObject) any processing will
end up here.

To ensure proper caching, it is important to separate the two main
actions `render` and `perform`, which unfortunately cannot be resolved
easily, especially when using custom Extbase controller actions.
The term uncached refers to using cObject `USER_INT` instead of `USER`.

More details about the process flow are described in
`\TYPO3\CMS\Form\Core\FormRequestHandler`, introduced by this change.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 9

Review log 2438

Show 713 earlier messages
  1. waldhacker uploaded patch set 1 08/12/21, 17:35

  2. waldhacker updated the commit message in patch set 2 08/12/21, 17:35

  3. core-ci voted on patch set 1 V +1 08/12/21, 17:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14815

  4. core-ci voted on patch set 2 V +1 08/12/21, 17:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14816

  5. waldhacker commented on patch set 3 08/12/21, 22:15

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 08/12/21, 22:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14865

  7. waldhacker rebased onto patch set 4 08/12/21, 23:08

  8. core-ci voted on patch set 4 V +1 08/12/21, 23:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14870

  9. waldhacker voted on patch set 4 CR -1 08/13/21, 09:46

  10. waldhacker uploaded patch set 5 08/13/21, 19:34

  11. core-ci voted on patch set 5 V +1 08/13/21, 19:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15020

  12. waldhacker updated the commit message in patch set 6 08/14/21, 08:55

  13. core-ci voted on patch set 6 V +1 08/14/21, 09:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15041

  1. waldhacker uploaded patch set 7 08/14/21, 14:13

  2. core-ci voted on patch set 7 V +1 08/14/21, 14:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15085

  3. waldhacker updated the commit message in patch set 8 08/14/21, 17:03

  4. core-ci voted on patch set 8 V +1 08/14/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15102

  5. waldhacker abandoned the change 02/24/22, 18:02

  6. waldhacker restored the change 07/28/22, 14:23

  7. waldhacker uploaded patch set 9 07/28/22, 14:23

  8. waldhacker uploaded patch set 10 07/28/22, 14:26

  9. waldhacker uploaded patch set 11 07/28/22, 14:30

  10. core-ci voted on patch set 9 V +1 07/28/22, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29656

  11. core-ci voted on patch set 10 V +1 07/28/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29658

  12. core-ci voted on patch set 11 V +1 07/28/22, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29659

  13. Oliver Hader commented on patch set 11 CR -1 07/28/22, 14:49

  14. waldhacker uploaded patch set 12 07/28/22, 14:52

  15. waldhacker commented on patch set 12 07/28/22, 14:53

    Reply

    Done
  16. core-ci voted on patch set 12 V +1 07/28/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29661

  17. waldhacker commented on patch set 13 07/29/22, 14:11

    Published edit on patch set 12.
  18. core-ci voted on patch set 13 V +1 07/29/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29700

  19. waldhacker commented on patch set 14 07/29/22, 14:37

    Published edit on patch set 13.
  20. core-ci voted on patch set 14 V +1 07/29/22, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29705

  21. Oliver Hader commented on patch set 14 CR -2 08/29/22, 08:20

    Blocked for the time being... new regressions have been discovered, e.g. https://forge.typo3.org/issues/98222
  22. Oliver Hader commented on patch set 14 V -1 09/12/22, 19:18

    There are aims to revert the whole bunch of changes for the time being in `main` and `11.5` branch: https://review.typo3.org/q/I731069b7d2485bf1bd94e78ebe3e9500d2a752ea
  23. Oliver Hader marked it work in progress 09/12/22, 19:18

  24. Christian Kuhn commented on patch set 14 11/20/22, 14:46

    this has been reverted in main & v11 with https://forge.typo3.org/issues/98336
  25. Christian Kuhn abandoned the change 11/20/22, 14:46