70513[BUGFIX] Ensure uncached forms in case of POST requests
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 9
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+9 −5
- typo3/sysext/form/Classes/Core/FormRequestHandler.phpnew+231 −0
- typo3/sysext/form/Classes/Domain/Factory/FormFactoryInterface.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+24 −26
- typo3/sysext/form/Classes/ViewHelpers/FormViewHelper.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+25 −44
- typo3/sysext/form/Configuration/Services.yaml+3 −0
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+42 −54
- typo3/sysext/form/ext_localconf.php+3 −1
Review log 2438
Show 713 earlier messages
-
waldhacker uploaded patch set 1 08/12/21, 17:35
-
waldhacker updated the commit message in patch set 2 08/12/21, 17:35
-
core-ci voted on patch set 1 V +1 08/12/21, 17:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14815
-
core-ci voted on patch set 2 V +1 08/12/21, 17:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14816
-
waldhacker commented on patch set 3 08/12/21, 22:15
Published edit on patch set 2. -
core-ci voted on patch set 3 V +1 08/12/21, 22:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14865
-
waldhacker rebased onto patch set 4 08/12/21, 23:08
-
core-ci voted on patch set 4 V +1 08/12/21, 23:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14870
-
waldhacker voted on patch set 4 CR -1 08/13/21, 09:46
-
waldhacker uploaded patch set 5 08/13/21, 19:34
-
core-ci voted on patch set 5 V +1 08/13/21, 19:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15020
-
waldhacker updated the commit message in patch set 6 08/14/21, 08:55
-
core-ci voted on patch set 6 V +1 08/14/21, 09:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15041
-
waldhacker uploaded patch set 7 08/14/21, 14:13
-
core-ci voted on patch set 7 V +1 08/14/21, 14:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15085
-
waldhacker updated the commit message in patch set 8 08/14/21, 17:03
-
core-ci voted on patch set 8 V +1 08/14/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15102
-
waldhacker abandoned the change 02/24/22, 18:02
-
waldhacker restored the change 07/28/22, 14:23
-
waldhacker uploaded patch set 9 07/28/22, 14:23
-
waldhacker uploaded patch set 10 07/28/22, 14:26
-
waldhacker uploaded patch set 11 07/28/22, 14:30
-
core-ci voted on patch set 9 V +1 07/28/22, 14:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29656
-
core-ci voted on patch set 10 V +1 07/28/22, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29658
-
core-ci voted on patch set 11 V +1 07/28/22, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29659
-
Oliver Hader commented on patch set 11 CR -1 07/28/22, 14:49
Can you please enable those disabled test sets of https://review.typo3.org/c/Packages/TYPO3.CMS/+/75326/4/typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php? Thanks in advance! -
waldhacker uploaded patch set 12 07/28/22, 14:52
-
waldhacker commented on patch set 12 07/28/22, 14:53
Reply
Done -
core-ci voted on patch set 12 V +1 07/28/22, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29661
-
waldhacker commented on patch set 13 07/29/22, 14:11
Published edit on patch set 12. -
core-ci voted on patch set 13 V +1 07/29/22, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29700
-
waldhacker commented on patch set 14 07/29/22, 14:37
Published edit on patch set 13. -
core-ci voted on patch set 14 V +1 07/29/22, 14:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29705
-
Oliver Hader commented on patch set 14 CR -2 08/29/22, 08:20
Blocked for the time being... new regressions have been discovered, e.g. https://forge.typo3.org/issues/98222 -
Oliver Hader commented on patch set 14 V -1 09/12/22, 19:18
There are aims to revert the whole bunch of changes for the time being in `main` and `11.5` branch: https://review.typo3.org/q/I731069b7d2485bf1bd94e78ebe3e9500d2a752ea -
Oliver Hader marked it work in progress 09/12/22, 19:18
-
Christian Kuhn commented on patch set 14 11/20/22, 14:46
this has been reverted in main & v11 with https://forge.typo3.org/issues/98336 -
Christian Kuhn abandoned the change 11/20/22, 14:46