Review main Merged

70516[TASK] Upgrade php-cs-fixer to latest version v3

Wouter Wolters CR +2 V +2 Normal +51 −141 updated 08/13/21, 21:56

Commit message

diff-format option has been removed. udiff is the default
now since v3.

composer u friendsofphp/php-cs-fixer composer/xdebug-handler php-cs-fixer/diff
composer req --dev friendsofphp/php-cs-fixer:^3.0

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 710

  1. Wouter Wolters uploaded patch set 1 08/12/21, 18:23

  2. Wouter Wolters uploaded patch set 2 08/12/21, 18:25

  3. core-ci voted on patch set 1 V -1 08/12/21, 18:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14824

  4. core-ci voted on patch set 2 V -1 08/12/21, 18:28 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14825

  5. Wouter Wolters uploaded patch set 3 08/12/21, 18:31

  6. Wouter Wolters updated the commit message in patch set 4 08/12/21, 18:39

  7. core-ci voted on patch set 4 V +1 08/12/21, 18:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14828

  8. Christian Kuhn voted on patch set 4 V +1 CR +1 08/13/21, 21:23

  9. Benni Mack voted on patch set 4 V +2 CR +2 08/13/21, 21:56

  10. Benni Mack merged patch set 5 08/13/21, 21:56