Review 10.4 Merged

70517[BUGFIX] Re-add language switcher for sys_file_metadata records

Oli Bartsch CR +2 V +2 Easy +10 −15 updated 08/12/21, 19:11

Commit message

Using the TranslationConfigurationProvider API returns an array
of available languages for a given site (and on pid=0 returns the
available translations as well), brings back the Language Switcher
when editing sys_file_metadata records.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 08/12/21, 18:49

  2. Wouter Wolters commented on patch set 1 V +1 CR +1 08/12/21, 18:52

    Same as in master
  3. Oli Bartsch commented on patch set 1 08/12/21, 18:54

    Reply

    Yes, except the shorthanded arrow function, which is not available for PHP < 7.4
  4. core-ci voted on patch set 1 V +1 08/12/21, 18:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14831

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 08/12/21, 19:10

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 08/12/21, 19:10

  7. Oli Bartsch merged patch set 2 08/12/21, 19:11