70521[FEATURE] Add support for an object interface on top of the config array.
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 13
- Build/Scripts/annotationChecker.php+5 −1
- typo3/sysext/core/Classes/Config/Config.phpnew+40 −0
- typo3/sysext/core/Classes/Config/ConfigFactory.phpnew+42 −0
- typo3/sysext/core/Classes/Config/GfxConfig.php2new+93 −0
- typo3/sysext/core/Classes/Config/Http.phpnew+67 −0
- typo3/sysext/core/Classes/Config/MailConfig.phpnew+133 −0
- typo3/sysext/core/Classes/DependencyInjection/ConfigDefinitionPass.phpnew+84 −0
- typo3/sysext/core/Configuration/Services.php+4 −0
- typo3/sysext/core/Configuration/Services.yaml+48 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/filelist/Classes/Controller/FileListController.php+7 −3
- composer.json+1 −0
- composer.lock+104 −2
Review log 1725
-
crell uploaded patch set 1 08/12/21, 19:20
-
core-ci voted on patch set 1 V -1 08/12/21, 19:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14837
-
crell uploaded patch set 2 08/13/21, 17:22
-
core-ci voted on patch set 2 V -1 08/13/21, 17:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15007
-
crell uploaded patch set 3 08/13/21, 17:28
-
core-ci voted on patch set 3 V -1 08/13/21, 17:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15008
-
crell uploaded patch set 4 08/16/21, 15:51
-
core-ci voted on patch set 4 V -1 08/16/21, 15:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15196
-
crell uploaded patch set 5 08/16/21, 16:18
-
core-ci voted on patch set 5 V -1 08/16/21, 16:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15197
-
crell uploaded patch set 6 08/16/21, 17:03
-
core-ci voted on patch set 6 V -1 08/16/21, 17:23 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15200
-
Oliver Klee commented on patch set 6 08/16/21, 18:52
-
crell uploaded patch set 7 08/20/21, 18:50
-
core-ci voted on patch set 7 V -1 08/20/21, 19:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15347
-
crell marked it work in progress 08/20/21, 19:46
-
crell uploaded patch set 8 08/20/21, 20:28
-
crell commented on patch set 8 08/20/21, 20:30
This change is ready for review.GfxConfig.php:86ReplyOoof, yeah, that's why I hate PHP 7.4 for this. Copy-pasta everywhere. -
core-ci voted on patch set 8 V +1 08/20/21, 20:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15353
-
Oliver Klee wrote 08/20/21, 21:39
Removed reviewer Oliver Klee. -
Oliver Klee commented on patch set 8 CR -1 08/20/21, 21:40
The ticket is still missing here. -
crell commented on patch set 8 08/23/21, 14:37
Reply
Yes, this is just a demo/PoC. It's not going to get merged to v11. Assuming we decide to proceed for v12, I'll redo it using just attributes and other PHP 8 syntax, probably after PHP 8.1 is released so I can use readonly. The open question is which serialization library to use. cf: https://decisions.typo3.org/t/object-interface-to-typo3-conf-vars/706/ -
Oliver Klee wrote 08/28/21, 14:19
Removed reviewer Oliver Klee with the following votes: * Code-Review-1 by Oliver Klee <typo3-coding@oliverklee.de> -
Christian Kuhn commented on patch set 8 11/03/21, 16:42
Hey. I hope it's ok to abandon this demo patch for now: It can of course still be referenced when referring to it in conversation, but it probably won't make it as such and will probably not be finished soon as it looks right now. If work is continued here, it can be resurrected, too. -
Christian Kuhn abandoned the change 11/03/21, 16:42
GfxConfig.php:86