Review main Merged

70524[TASK] Add test method prefix checker to gitlab-ci

Wouter Wolters CR +2 V +2 Normal +117 −0 updated 08/13/21, 21:10

Commit message

Test methods are not allowed to have a prefix "test".
Use the annotation "@test" in phpDoc instead.

Integration into pre-merge and nightly gitlab-ci suites.

Note we now have multiple tests based on nikic/php-parser.
Those should be rewritten to use one parser instance with
multiple visitors to scan php code only once. The
exception code checker should be rewritten to use
the parser, too. This will be done with a dedicated patch.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • waldhacker +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • waldhacker +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1930

Show 35 earlier messages
  1. Wouter Wolters uploaded patch set 1 08/12/21, 20:32

  2. core-ci voted on patch set 1 V -1 08/12/21, 20:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14849

  3. Wouter Wolters uploaded patch set 2 08/12/21, 20:33

  4. core-ci voted on patch set 2 V -1 08/12/21, 20:37 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14850

  5. Wouter Wolters uploaded patch set 3 08/12/21, 20:43

  1. Wouter Wolters uploaded patch set 4 08/12/21, 20:51

  2. core-ci voted on patch set 3 V -1 08/12/21, 20:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14853

  3. Wouter Wolters uploaded patch set 5 08/12/21, 21:03

  4. core-ci voted on patch set 4 V -1 08/12/21, 21:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14856

  5. Wouter Wolters uploaded patch set 6 08/12/21, 21:13

  6. Wouter Wolters commented on patch set 6 08/12/21, 21:14

    In https://gitlab.typo3.org/typo3/CI/cms/-/jobs/371392 you can see 2 failures which I introduced to see the checker in action. One in a Unit test and one in a Functional test. The core is clean at the moment as we fixed everything this afternoon already.
  7. core-ci voted on patch set 5 V -1 08/12/21, 21:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14861

  8. core-ci voted on patch set 6 V +1 08/12/21, 21:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14862

  9. Christian Kuhn uploaded patch set 7 08/13/21, 20:16

  10. Christian Kuhn commented on patch set 7 08/13/21, 20:16

    rebased
  11. Christian Kuhn uploaded patch set 8 08/13/21, 20:39

  12. core-ci voted on patch set 7 V +1 08/13/21, 20:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15026

  13. Christian Kuhn commented on patch set 8 08/13/21, 20:40

    cosmetics, added to 'general' integrity job since the test is relatively quick, better error message.
  14. Christian Kuhn updated the commit message in patch set 9 08/13/21, 20:42

  15. Christian Kuhn uploaded patch set 10 08/13/21, 20:43

  16. Christian Kuhn commented on patch set 10 08/13/21, 20:43

    set 10 *should* fail.
  17. core-ci voted on patch set 8 V +1 08/13/21, 20:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15028

  18. core-ci voted on patch set 9 V +1 08/13/21, 20:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15029

  19. Christian Kuhn uploaded patch set 11 08/13/21, 20:56

  20. Christian Kuhn voted on patch set 11 V +1 CR +1 08/13/21, 20:59

  21. waldhacker voted on patch set 11 V +1 CR +1 08/13/21, 21:01

  22. core-ci voted on patch set 10 V -1 08/13/21, 21:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15030

  23. core-ci voted on patch set 11 V +1 08/13/21, 21:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15031

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 08/13/21, 21:10

  25. Christian Kuhn merged patch set 12 08/13/21, 21:10