Review 9.5 Merged

70526[FEATURE] Introduce explicit f:sanitize.html view-helper

Oliver Hader CR +2 V +2 Normal +242 −1 updated 08/13/21, 19:59

Commit message

New `<f:sanitize.html build="default">` view-helper is introduced
which directly invokes processing of `typo3/html-sanitize` package. An
optional view-helper argument `build` allows using a defined preset,
or a fully qualified class name of a builder instance as alternative,
which has to implement `\TYPO3\HtmlSanitizer\Builder\BuilderInterface`.

In contrast to `<f:format.html>`, this does NOT invoke `lib.parseFunc`,
and does NOT rely on TypoScript configuration being loaded and parsed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 811

  1. Oliver Hader uploaded patch set 1 08/12/21, 21:02

  2. core-ci voted on patch set 1 V +1 08/12/21, 21:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14860

  3. Oliver Hader commented on patch set 2 08/13/21, 08:00

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 08/13/21, 08:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14893

  5. Oliver Hader uploaded patch set 3 08/13/21, 09:11

  6. Helmut Hummel commented on patch set 3 08/13/21, 09:19

    HtmlViewHelper.php:101

    I'd do one instanceof check instead
  7. core-ci voted on patch set 3 V +1 08/13/21, 09:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14909

  8. Benni Mack voted on patch set 3 V +1 CR +1 08/13/21, 14:32

  9. Oliver Hader commented on patch set 3 08/13/21, 15:26

    HtmlViewHelper.php:101 Reply Unresolved

    `instanceof` does not work on strings
  10. Benni Mack voted on patch set 3 V +2 CR +2 08/13/21, 19:59

  11. Benni Mack merged patch set 4 08/13/21, 19:59