Review main Merged

70535[TASK] Extend acceptance tests for template module

Benjamin Tammling CR +2 V +2 Normal +63 −0 updated 10/01/21, 10:37

Commit message

Add tests to check:
* if the button to show the closest template is working as expected
* a new extension template is created when the appropriate button is used

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Benjamin Tammling uploaded patch set 1 08/13/21, 06:19

  2. core-ci voted on patch set 1 V +1 08/13/21, 06:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14882

  3. Benjamin Tammling updated the commit message in patch set 2 08/13/21, 06:42

  4. core-ci voted on patch set 2 V +1 08/13/21, 06:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14884

  5. Benni Mack commented on patch set 2 09/30/21, 14:52

    care to rebase?
  6. Nikita Hovratov uploaded patch set 3 10/01/21, 09:12

  7. core-ci voted on patch set 3 V -1 10/01/21, 09:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17390

  8. Nikita Hovratov uploaded patch set 4 10/01/21, 09:27

  9. core-ci voted on patch set 4 V +1 10/01/21, 09:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17394

  10. Benni Mack voted on patch set 4 V +1 CR +1 10/01/21, 10:27

  11. Georg Ringer voted on patch set 4 V +2 CR +2 10/01/21, 10:37

  12. Georg Ringer merged patch set 5 10/01/21, 10:37