Review main Merged

70536[BUGFIX] Remove unnecessary html tags

Andrzej Kołbuc CR +2 V +2 Easy +5 −5 updated 08/23/21, 23:05

Commit message

Labels are rendered by CshViewHelper which do htmlspecialchars on it. Next step todo is change whole additional fields layout and prepare translations.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • kharaf +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • kharaf +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Andrzej Kołbuc uploaded patch set 1 08/13/21, 07:50

  2. core-ci voted on patch set 1 V +1 08/13/21, 08:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14888

  3. kharaf commented on patch set 1 V +1 CR +1 08/13/21, 12:18

    I check your bugfix, everything is ok, now no tags html in my results.
  4. Rudy Gnodde voted on patch set 1 CR +1 08/13/21, 14:23

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 08/23/21, 23:04

  6. Christian Kuhn commented on patch set 1 08/23/21, 23:05

    confirmed. thanks!
  7. Christian Kuhn merged patch set 2 08/23/21, 23:05