70537[BUGFIX] Adjust default behavior of HTML sanitization in parseFunc
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
-
Verified V +2 Done
- Benni Mack +2
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+2 −2
- typo3/sysext/core/Configuration/DefaultConfiguration.php+2 −1
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+6 −3
- typo3/sysext/core/Documentation/Changelog/9.5.x/Important-94484-IntroduceHTMLSanitizer.rst+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/SecurityTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php+1 −1
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/Fixtures/FluidTemplate.html+3 −0
- typo3/sysext/fluid_styled_content/Tests/Functional/Rendering/SecureHtmlRenderingTest.php+142 −10
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php2+19 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+4 −510
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTestTrait.phpnew+205 −0
- typo3/sysext/frontend/Tests/UnitDeprecated/ContentObject/ContentObjectRendererTest.phpnew+496 −0
Review log 1218
-
Oliver Hader uploaded patch set 1 08/13/21, 08:36
-
core-ci voted on patch set 1 V -1 08/13/21, 08:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14896
-
Wouter Wolters commented on patch set 1 08/13/21, 15:35
-
Oliver Hader commented on patch set 1 08/14/21, 06:25
ContentObjectRenderer.php:3761Reply UnresolvedPreviously `htmlSanitize` was enabled per default, if not given. With this change it is relaxed and disabled per default - but triggering that deprecation log, that integrators have to really make a decision in the future - and to explicitly(!) disable it. Where did you find it is "on by default"? -
Oliver Hader uploaded patch set 2 08/14/21, 06:27
-
core-ci voted on patch set 2 V -1 08/14/21, 06:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15037
-
Oliver Hader uploaded patch set 3 08/14/21, 06:56
-
core-ci voted on patch set 3 V -1 08/14/21, 06:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15039
-
Oliver Hader uploaded patch set 4 08/14/21, 09:10
-
core-ci voted on patch set 4 V +1 08/14/21, 09:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15045
-
Oliver Hader uploaded patch set 5 08/16/21, 09:47
-
core-ci voted on patch set 5 V +1 08/16/21, 10:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15152
-
Oliver Hader uploaded patch set 6 08/16/21, 10:30
-
Oliver Hader marked it ready for review 08/16/21, 10:34
-
Benni Mack voted on patch set 6 V +1 CR +1 08/16/21, 10:34
-
core-ci commented on patch set 6 08/16/21, 10:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15155
-
Benni Mack voted on patch set 6 V +2 CR +2 08/16/21, 11:22
-
Benni Mack merged patch set 7 08/16/21, 11:22
ContentObjectRenderer.php:3761