Review main Merged

70538[DOCS] Exclude form finisher options from overrides

Björn Jacob CR +2 V +2 Easy +35 −5 updated 08/13/21, 13:21

Commit message

The documentation describes how to exclude specific options
from being overridden via the form plugin.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • waldhacker +2
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1015

  1. Björn Jacob uploaded patch set 1 08/13/21, 09:04

  2. Björn Jacob uploaded patch set 2 08/13/21, 09:05

  3. Mathias Brodala commented on patch set 2 08/13/21, 09:15

    Index.rst:31

    exclude-override

    Index.rst:37

    This should not be marked as code but be a regular text. Also we should put more emphasis on "Flexform" here since that's used regularly in the form docs. This should make the distinction clearer.

    Index.rst:39

    ... using the YAML NULL (~) value.

    Index.rst:39

    from

    Index.rst:40

    . The Form editor is not affected by this.
  4. core-ci voted on patch set 1 V -1 08/13/21, 09:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14900

  5. core-ci voted on patch set 2 V +1 08/13/21, 09:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14902

  6. Björn Jacob uploaded patch set 3 08/13/21, 09:53

  7. Björn Jacob commented on patch set 2 08/13/21, 09:53

    Index.rst:31 Reply

    Done

    Index.rst:37 Reply Unresolved

    Removed the formatting. Did not change anything regarding "Flexform" stuff. Couldn't find those parts in the docs where "Flexform" is stressed. Dou you have an example?

    Index.rst:39 Reply

    Done

    Index.rst:39 Reply

    Done

    Index.rst:40 Reply

    Done
  8. Björn Jacob uploaded patch set 4 08/13/21, 09:53

  9. core-ci commented on patch set 3 08/13/21, 10:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14918

  10. Mathias Brodala commented on patch set 5 08/13/21, 10:16

    Published edit on patch set 4.
  11. core-ci voted on patch set 4 V +1 08/13/21, 10:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14919

  12. Mathias Brodala commented on patch set 5 V +1 CR +1 08/13/21, 10:16

    Verified by use in production. ;-)
  13. core-ci voted on patch set 5 V +1 08/13/21, 10:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14924

  14. waldhacker voted on patch set 5 V +2 CR +2 08/13/21, 13:21

  15. waldhacker merged patch set 6 08/13/21, 13:21