Review main Merged

70539[BUGFIX] ext:lowlevel advanced query where clauses

Andrzej Kołbuc CR +2 V +2 Easy +2 −1 updated 08/14/21, 11:54

Commit message

* "Make query" vanished from the interface since #94121
due to a broken type comparison on $this->queryConfig.
* Date fields now properly load date pickers.

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1114

  1. Andrzej Kołbuc uploaded patch set 1 08/13/21, 09:07

  2. core-ci voted on patch set 1 V +1 08/13/21, 09:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14905

  3. kharaf commented on patch set 1 V +1 CR +1 08/13/21, 12:09

    everything is ok.
  4. Łukasz Uznański voted on patch set 1 CR +1 08/13/21, 14:09

  5. Rudy Gnodde voted on patch set 1 CR +1 08/13/21, 14:29

  6. Marcin Sągol voted on patch set 1 V +1 CR +1 08/13/21, 14:51

  7. Andrzej Kołbuc uploaded patch set 2 08/13/21, 15:52

  8. core-ci voted on patch set 2 V +1 08/13/21, 16:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14996

  9. Christian Kuhn uploaded patch set 3 08/13/21, 16:15

  10. Christian Kuhn commented on patch set 3 V +1 CR +1 08/13/21, 16:16

    Thanks for making "make query" show up again. Just cleaned up commit message a bit with set 3.
  11. Wouter Wolters voted on patch set 3 CR +1 08/13/21, 16:18

  12. core-ci voted on patch set 3 V +1 08/13/21, 16:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14997

  13. Tymoteusz Motylewski voted on patch set 3 V +2 CR +2 08/14/21, 11:53

  14. Tymoteusz Motylewski merged patch set 4 08/14/21, 11:54