70540[TASK] Show full readable path of allowedFileMounts
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
- Guido Schmechel +1
- Andreas Steiger +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- Andreas Steiger +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1926
Show 1 earlier messages
-
Andreas Steiger uploaded patch set 1 08/13/21, 09:21
-
core-ci voted on patch set 1 V -1 08/13/21, 09:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14910
-
Björn Jacob updated the commit message in patch set 2 08/13/21, 10:22
-
Björn Jacob voted on patch set 2 V +1 CR +1 08/13/21, 10:33
-
core-ci voted on patch set 2 V -1 08/13/21, 10:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14928
-
Guido Schmechel commented on patch set 2 08/13/21, 10:42
-
Björn Jacob commented on patch set 2 V 0 CR 0 08/13/21, 11:21
Will test it with private storage. -
Björn Jacob commented on patch set 2 CR -1 08/13/21, 11:42
If the storage is not publicly available, the label is "null". My suggestion: * add condition * repair unit tests * add unit tests for this case -
waldhacker uploaded patch set 3 08/13/21, 13:09
-
core-ci voted on patch set 3 V +1 08/13/21, 13:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14967
-
waldhacker voted on patch set 3 CR -1 08/13/21, 13:40
-
Björn Jacob commented on patch set 3 V -1 08/13/21, 14:24
-1 because non public storages are not respected. -
Andreas Steiger uploaded patch set 4 08/14/21, 09:38
-
waldhacker updated the commit message in patch set 5 08/14/21, 09:39
-
core-ci voted on patch set 4 V -1 08/14/21, 09:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15046
-
core-ci voted on patch set 5 V -1 08/14/21, 09:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15048
-
waldhacker uploaded patch set 6 08/14/21, 14:24
-
core-ci voted on patch set 6 V +1 08/14/21, 14:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15086
-
Björn Jacob updated the commit message in patch set 7 08/16/21, 15:14
-
Björn Jacob voted on patch set 7 V +1 CR +1 08/16/21, 15:25
-
core-ci voted on patch set 7 V +1 08/16/21, 15:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15193
-
Andreas Steiger voted on patch set 7 V +1 CR +1 08/16/21, 18:56
-
Guido Schmechel voted on patch set 7 CR +1 08/16/21, 22:45
-
waldhacker voted on patch set 7 V +2 CR +2 08/18/21, 18:17
-
waldhacker commented on patch set 7 08/18/21, 18:18
FormManagerController.php:363ReplyDone -
waldhacker merged patch set 8 08/18/21, 18:18
FormManagerController.php:363