Review main Merged

70540[TASK] Show full readable path of allowedFileMounts

Andreas Steiger CR +2 V +2 Easy +18 −12 updated 08/18/21, 18:18

Commit message

The label of the select field 'allowedFileMounts' in the form
wizard has been optimized. Now, the label is more readable and
less technical.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Guido Schmechel +1
    • Andreas Steiger +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • Andreas Steiger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1926

Show 1 earlier messages
  1. Andreas Steiger uploaded patch set 1 08/13/21, 09:21

  1. core-ci voted on patch set 1 V -1 08/13/21, 09:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14910

  2. Björn Jacob updated the commit message in patch set 2 08/13/21, 10:22

  3. Björn Jacob voted on patch set 2 V +1 CR +1 08/13/21, 10:33

  4. core-ci voted on patch set 2 V -1 08/13/21, 10:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14928

  5. Guido Schmechel commented on patch set 2 08/13/21, 10:42

    FormManagerController.php:363

    Without knowing the code exactly, I'll ask the stupid question: Is it possible to have forms in a private storage, so that publicUrl() returns nothing? I would then use the name as a fallback. If not possible: Feel free to ignore ;-)
  6. Björn Jacob commented on patch set 2 V 0 CR 0 08/13/21, 11:21

    Will test it with private storage.
  7. Björn Jacob commented on patch set 2 CR -1 08/13/21, 11:42

    If the storage is not publicly available, the label is "null". My suggestion: * add condition * repair unit tests * add unit tests for this case
  8. waldhacker uploaded patch set 3 08/13/21, 13:09

  9. core-ci voted on patch set 3 V +1 08/13/21, 13:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14967

  10. waldhacker voted on patch set 3 CR -1 08/13/21, 13:40

  11. Björn Jacob commented on patch set 3 V -1 08/13/21, 14:24

    -1 because non public storages are not respected.
  12. Andreas Steiger uploaded patch set 4 08/14/21, 09:38

  13. waldhacker updated the commit message in patch set 5 08/14/21, 09:39

  14. core-ci voted on patch set 4 V -1 08/14/21, 09:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15046

  15. core-ci voted on patch set 5 V -1 08/14/21, 09:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15048

  16. waldhacker uploaded patch set 6 08/14/21, 14:24

  17. core-ci voted on patch set 6 V +1 08/14/21, 14:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15086

  18. Björn Jacob updated the commit message in patch set 7 08/16/21, 15:14

  19. Björn Jacob voted on patch set 7 V +1 CR +1 08/16/21, 15:25

  20. core-ci voted on patch set 7 V +1 08/16/21, 15:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15193

  21. Andreas Steiger voted on patch set 7 V +1 CR +1 08/16/21, 18:56

  22. Guido Schmechel voted on patch set 7 CR +1 08/16/21, 22:45

  23. waldhacker voted on patch set 7 V +2 CR +2 08/18/21, 18:17

  24. waldhacker commented on patch set 7 08/18/21, 18:18

    FormManagerController.php:363 Reply

    Done
  25. waldhacker merged patch set 8 08/18/21, 18:18