70543[TASK] Strictify Tests part 3 - backend
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 123
- typo3/sysext/backend/Tests/Functional/Authentication/PasswordResetTest.php+3 −1
- typo3/sysext/backend/Tests/Functional/Clipboard/ClipboardTest.php+4 −11
- typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/SiteConfigurationOverridesTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+3 −1
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+12 −12
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+2 −5
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+5 −8
- typo3/sysext/backend/Tests/Functional/Controller/MfaConfigurationControllerTest.php+1 −0
- typo3/sysext/backend/Tests/Functional/Controller/MfaControllerTest.php+3 −1
- typo3/sysext/backend/Tests/Functional/Controller/ResetPasswordControllerTest.php+6 −1
- typo3/sysext/backend/Tests/Functional/Domain/Repository/Localization/LocalizationRepositoryTest.php+4 −3
- typo3/sysext/backend/Tests/Functional/Form/FormTestService.php+1 −1
- typo3/sysext/backend/Tests/Functional/Form/MfaInfoElementTest.php+3 −1
- typo3/sysext/backend/Tests/Functional/History/RecordHistoryStoreTest.php+4 −4
- typo3/sysext/backend/Tests/Functional/History/RecordHistoryTest.php+1 −4
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+0 −3
- typo3/sysext/backend/Tests/Functional/View/Drawing/BackendLayoutRendererTest.php+13 −12
- typo3/sysext/backend/Tests/Functional/View/PageLayoutViewTest.php+5 −3
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Link/EditRecordViewHelperTest.php+6 −6
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Link/NewRecordViewHelperTest.php+8 −8
Show 103 more files
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Mfa/IfHasStateViewHelperTest.php+1 −1
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Uri/EditRecordViewHelperTest.php+6 −6
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Uri/NewRecordViewHelperTest.php+9 −9
- typo3/sysext/backend/Tests/Unit/Configuration/BackendUserConfigurationTest.php+14 −11
- typo3/sysext/backend/Tests/Unit/Configuration/TranslationConfigurationProviderTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+25 −21
- typo3/sysext/backend/Tests/Unit/Controller/File/ThumbnailControllerTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Controller/Wizard/SuggestWizardControllerTest.php+3 −1
- typo3/sysext/backend/Tests/Unit/Controller/EditDocumentControllerTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Controller/FormInlineAjaxControllerTest.php+3 −1
- typo3/sysext/backend/Tests/Unit/Controller/FormSelectTreeAjaxControllerTest.php+5 −3
- typo3/sysext/backend/Tests/Unit/Controller/LoginControllerTest.php+7 −3
- typo3/sysext/backend/Tests/Unit/Controller/SiteConfigurationControllerTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/SwitchUserControllerTest.php+0 −1
- typo3/sysext/backend/Tests/Unit/Form/Container/ListOfFieldsContainerTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Form/Container/PaletteAndSingleContainerTest.php+6 −4
- typo3/sysext/backend/Tests/Unit/Form/Element/AbstractFormElementTest.php+5 −9
- typo3/sysext/backend/Tests/Unit/Form/Element/InputDateTimeElementTest.php+6 −12
- typo3/sysext/backend/Tests/Unit/Form/Element/InputHiddenElementTest.php+4 −2
- typo3/sysext/backend/Tests/Unit/Form/FieldControl/ElementBrowserTest.php+3 −1
- typo3/sysext/backend/Tests/Unit/Form/Fixtures/NodeFactory/NodeResolvers/BarResolver.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/Fixtures/NodeFactory/NodeResolvers/FooResolver.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/FlexFormSegmentTest.php+7 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OnTheFlyTest.php+8 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OrderedProviderListTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/SiteConfigurationDataGroupTest.php+7 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaDatabaseRecordTest.php+7 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaInputPlaceholderRecordTest.php+7 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaSelectTreeAjaxFieldDataTest.php+7 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+6 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEditRowTest.php+10 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseEffectivePidTest.php+5 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseLanguageRowsTest.php+14 −11
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabasePageLanguageOverlayRowsTest.php+4 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseParentPageRowTest.php+8 −7
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordOverrideValuesTest.php+3 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRecordTypeValueTest.php+17 −16
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDateTimeFieldsTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDefaultValuesTest.php+6 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowInitializeNewTest.php+24 −24
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseSystemLanguageRowsTest.php+5 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUniqueUidNewRowTest.php+5 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseUserPermissionCheckTest.php+22 −20
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/EvaluateDisplayConditionsTest.php+45 −43
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php+5 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InlineOverrideChildTcaTest.php+6 −9
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/PageTsConfigMergedTest.php+5 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteDatabaseEditRowTest.php+11 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/SiteResolvingTest.php+5 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaCheckboxItemsTest.php+11 −18
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsOverridesTest.php+4 −7
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessCommonTest.php+8 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessFieldDescriptionsTest.php+3 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessFieldLabelsTest.php+8 −6
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessPlaceholdersTest.php+4 −7
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessRecordTitleTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsProcessShowitemTest.php+7 −7
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsRemoveUnusedTest.php+2 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexPrepareTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaFlexProcessTest.php+25 −24
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaGroupTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php+20 −20
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineExpandCollapseStateTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineIsOnSymmetricSideTest.php+2 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInputPlaceholdersTest.php+12 −10
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php+3 −12
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRadioItemsTest.php+13 −11
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php+28 −44
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+7 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+6 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSlugTest.php+1 −4
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTypesShowitemTest.php+8 −11
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/UserTsConfigTest.php+5 −6
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+4 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataCompilerTest.php+16 −17
- typo3/sysext/backend/Tests/Unit/Form/InlineStackProcessorTest.php+12 −17
- typo3/sysext/backend/Tests/Unit/Form/NodeFactoryTest.php+28 −26
- typo3/sysext/backend/Tests/Unit/Http/Fixtures/RouteDispatcherClassFixture.php+1 −1
- typo3/sysext/backend/Tests/Unit/Http/Fixtures/RouteDispatcherStaticClassFixture.php+1 −1
- typo3/sysext/backend/Tests/Unit/Http/RouteDispatcherTest.php+11 −9
- typo3/sysext/backend/Tests/Unit/Middleware/SiteResolverTest.php+5 −3
- typo3/sysext/backend/Tests/Unit/Module/ModuleLoaderTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Routing/UriBuilderTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Security/EmailLoginNotificationTest.php+3 −1
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/FullyRenderedButtonTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/InputButtonTest.php+6 −6
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/LinkButtonTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Template/Components/Button/SplitButtonTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Template/Components/Menu/MenuItemTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Template/Components/MenuTest.php+4 −4
- typo3/sysext/backend/Tests/Unit/Tree/SortedTreeNodeCollectionTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Tree/TreeNodeCollectionTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Tree/TreeNodeTest.php+3 −3
- typo3/sysext/backend/Tests/Unit/Utility/Fixtures/LabelFromItemListMergedReturnsCorrectFieldsFixture.php+1 −4
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+67 −119
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/BackendLayoutCollectionTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/BackendLayoutTest.php+5 −3
- typo3/sysext/backend/Tests/Unit/View/BackendLayout/DataProviderCollectionTest.php+7 −10
- typo3/sysext/backend/Tests/Unit/View/ArrayBrowserTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/View/BackendLayoutViewTest.php+5 −4
- typo3/sysext/backend/Tests/UnitDeprecated/Form/FormDataProvider/TcaFlexPrepareTest.php+7 −8
- typo3/sysext/backend/Tests/UnitDeprecated/Utility/BackendUtilityTest.php+2 −2
Review log 1425
-
Roman Büchler uploaded patch set 1 08/13/21, 10:11
-
core-ci voted on patch set 1 V -1 08/13/21, 10:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14922
-
Roman Büchler uploaded patch set 2 08/13/21, 13:08
-
core-ci voted on patch set 2 V -1 08/13/21, 13:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14966
-
core-ci commented on patch set 2 08/13/21, 13:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14966
-
Roman Büchler rebased onto patch set 3 08/13/21, 13:40
-
Roman Büchler wrote 08/13/21, 13:53
Topic set to unit-strict -
core-ci commented on patch set 2 08/13/21, 13:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14966
-
core-ci voted on patch set 3 V +1 08/13/21, 14:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14971
-
Roman Büchler rebased onto patch set 4 08/14/21, 18:12
-
core-ci voted on patch set 4 V +1 08/14/21, 18:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15103
-
Roman Büchler rebased onto patch set 5 08/14/21, 18:30
-
core-ci voted on patch set 5 V +1 08/14/21, 18:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15105
-
Wouter Wolters uploaded patch set 6 08/15/21, 17:08
-
core-ci voted on patch set 6 V +1 08/15/21, 17:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15123
-
Wouter Wolters voted on patch set 6 V +1 CR +1 08/15/21, 17:26
-
Christian Kuhn updated the commit message in patch set 7 08/23/21, 22:50
-
core-ci voted on patch set 7 V +1 08/23/21, 23:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15469
-
Christian Kuhn rebased onto patch set 8 09/11/21, 11:17
-
Christian Kuhn uploaded patch set 9 09/11/21, 11:38
-
core-ci voted on patch set 8 V +1 09/11/21, 11:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16539
-
core-ci voted on patch set 9 V +1 09/11/21, 11:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16542
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 09/11/21, 12:18
-
Christian Kuhn voted on patch set 9 V +2 CR +2 09/11/21, 12:18
-
Christian Kuhn merged patch set 10 09/11/21, 12:18