Review main Merged

70547[BUGFIX] PSR-7 Uri implementation must return scheme as string

Benni Mack CR +2 V +2 Easy +4 −4 updated 08/27/21, 07:09

Commit message

TYPO3's PSR-7 implementation has a small flaw when having URLs
without a scheme, which should always return an empty string.

This change initializes the scheme with an empty string by default.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1016

  1. Benni Mack uploaded patch set 1 08/13/21, 11:03

  2. Rafael Kähm commented on patch set 1 V +1 CR +1 08/13/21, 11:08

    Tested successfully.
  3. Wouter Wolters voted on patch set 1 CR +1 08/13/21, 11:09

  4. core-ci voted on patch set 1 V -1 08/13/21, 13:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14940

  5. Benni Mack rebased onto patch set 2 08/14/21, 11:13

  6. core-ci voted on patch set 2 V -1 08/14/21, 13:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15058

  7. Benni Mack rebased onto patch set 3 08/23/21, 08:21

  8. core-ci voted on patch set 3 V -1 08/23/21, 10:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15404

  9. Benni Mack uploaded patch set 4 08/23/21, 11:29

  10. core-ci voted on patch set 4 V -1 08/23/21, 11:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15408

  11. Benjamin Franzke uploaded patch set 5 08/26/21, 22:00

  12. core-ci voted on patch set 5 V -1 08/26/21, 22:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15692

  13. Benjamin Franzke uploaded patch set 6 08/26/21, 22:43

  14. core-ci voted on patch set 6 V +1 08/26/21, 23:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15694

  15. Andreas Kienast voted on patch set 6 V +2 CR +2 08/27/21, 07:09

  16. Andreas Kienast merged patch set 7 08/27/21, 07:09