Review main Merged

70548[TASK] Use global namespace when concatenating ext_(localconf/tables)

Wouter Wolters CR +2 V +2 Easy +5 −0 updated 08/26/21, 07:41

Commit message

With using a global namespace the usage of use statements
is not a problem anymore.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • crell +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1519

  1. Wouter Wolters uploaded patch set 1 08/13/21, 11:06

  2. Benni Mack commented on patch set 1 08/13/21, 11:07

    ExtensionManagementUtility.php:1543

    should we also add this to loadSingleExtLocalconfFiles?
  3. core-ci voted on patch set 1 V -1 08/13/21, 11:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14942

  4. Wouter Wolters commented on patch set 2 08/13/21, 14:13

    Published edit on patch set 1.
  5. core-ci voted on patch set 2 V +1 08/13/21, 14:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14975

  6. Wouter Wolters commented on patch set 2 08/15/21, 12:41

    ExtensionManagementUtility.php:1543 Reply Unresolved

    So the same concatenate strategy and require that file as a whole?
  7. Benni Mack updated the commit message in patch set 3 08/24/21, 13:34

  8. Benni Mack voted on patch set 3 V +1 CR +1 08/24/21, 13:34

  9. core-ci voted on patch set 3 V +1 08/24/21, 13:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15511

  10. Andreas Kienast voted on patch set 3 CR +1 08/24/21, 13:56

  11. Benni Mack updated the commit message in patch set 4 08/24/21, 14:21

  12. core-ci voted on patch set 4 V +1 08/24/21, 14:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15515

  13. Andreas Kienast voted on patch set 4 CR +1 08/24/21, 14:45

  14. Oli Bartsch voted on patch set 4 V +1 CR +1 08/24/21, 16:27

  15. crell commented on patch set 4 CR +1 08/24/21, 18:36

    The braced-namespace syntax is under-rated... 👍
  16. Andreas Kienast voted on patch set 4 V +1 08/24/21, 18:56

  17. Andreas Kienast voted on patch set 4 V +2 CR +2 08/24/21, 18:57

  18. Andreas Kienast merged patch set 5 08/24/21, 18:57

  19. Mathias Brodala commented on patch set 5 CR +1 08/26/21, 07:41

    Post C+1 for this simple but awesome idea. 😊