70551[BUGFIX] Allow HTML node onclick events in generated frontend markup
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Html/DefaultSanitizerBuilder.php+13 −0
- typo3/sysext/core/Tests/Functional/Html/DefaultSanitizerBuilderTest.php+10 −0
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+3 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+4 −4
Review log 913
-
Oliver Hader uploaded patch set 1 08/13/21, 11:40
-
core-ci voted on patch set 1 V -1 08/13/21, 12:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14948
-
Oliver Hader uploaded patch set 2 08/13/21, 12:08
-
core-ci voted on patch set 2 V +1 08/13/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14954
-
Benni Mack voted on patch set 2 V +1 CR +1 08/13/21, 13:13
-
Benni Mack commented on patch set 2 08/13/21, 13:14
Thanks for providing such a fix so fast. It works like a charm. I don't know if this is regression would be worthy of a regression release? Unfortunately our projects strongly depend on this feature and we're stuck with the old versions. -
Wouter Wolters voted on patch set 2 CR +1 08/13/21, 13:15
-
Benni Mack updated the commit message in patch set 3 08/14/21, 11:17
-
Benni Mack voted on patch set 3 V +1 CR +1 08/14/21, 11:17
-
core-ci voted on patch set 3 V -1 08/14/21, 11:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15060
-
core-ci voted on patch set 3 V +1 08/15/21, 10:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15060
-
Oliver Hader voted on patch set 3 V +2 CR +2 08/16/21, 11:16
-
Oliver Hader merged patch set 4 08/16/21, 11:16