Review main Merged

70551[BUGFIX] Allow HTML node onclick events in generated frontend markup

Oliver Hader CR +2 V +2 Easy +32 −7 updated 08/16/21, 11:16

Commit message

`ContentObjectRenderer` and `AbstractMenuContentObject` are still relying
HTML event attribute `onclick` to open new client window instances,
which were (correctly) removed by HTML sanitizer.

In order to keep the functionality, exceptional declarations have been
added, and `vHWin=window.open(...)` substituted by `openPic(...)`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 913

  1. Oliver Hader uploaded patch set 1 08/13/21, 11:40

  2. core-ci voted on patch set 1 V -1 08/13/21, 12:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14948

  3. Oliver Hader uploaded patch set 2 08/13/21, 12:08

  4. core-ci voted on patch set 2 V +1 08/13/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14954

  5. Benni Mack voted on patch set 2 V +1 CR +1 08/13/21, 13:13

  6. Benni Mack commented on patch set 2 08/13/21, 13:14

    Thanks for providing such a fix so fast. It works like a charm. I don't know if this is regression would be worthy of a regression release? Unfortunately our projects strongly depend on this feature and we're stuck with the old versions.
  7. Wouter Wolters voted on patch set 2 CR +1 08/13/21, 13:15

  8. Benni Mack updated the commit message in patch set 3 08/14/21, 11:17

  9. Benni Mack voted on patch set 3 V +1 CR +1 08/14/21, 11:17

  10. core-ci voted on patch set 3 V -1 08/14/21, 11:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15060

  11. core-ci voted on patch set 3 V +1 08/15/21, 10:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15060

  12. Oliver Hader voted on patch set 3 V +2 CR +2 08/16/21, 11:16

  13. Oliver Hader merged patch set 4 08/16/21, 11:16