Review 10.4 Merged

70553[BUGFIX] Remove prefixed scriptName from urlPath in PageRouter

Benni Mack CR +2 V +2 Easy +20 −1 updated 08/24/21, 14:26

Commit message

Remove resolved scriptName with leading slash from url in
PageRouter matchRequest method.

This prevent to change the url to a invalid url if
PageTypeSuffix Decorator with .php is used and a page slugs
ends in index.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Benni Mack commented on patch set 1 08/13/21, 10:26

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/PageTypeDecoratorTest.php
  2. Benni Mack commented on patch set 2 08/13/21, 10:28

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 08/13/21, 10:28

  4. core-ci voted on patch set 1 V -1 08/13/21, 10:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14929

  5. core-ci voted on patch set 2 V +1 08/13/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14930

  6. Benni Mack voted on patch set 2 V +2 CR +2 08/13/21, 10:46

  7. Benni Mack merged patch set 3 08/13/21, 10:46

  8. Benni Mack wrote 08/24/21, 14:26

    Created a revert of this change as Icc497980b607612f4c702ad601b032d27fc7b7c0