Review main Merged

70573[BUGFIX] Use loading="lazy" in FormEngineUtility::getIconHtml()

Andreas Kienast CR +2 V +2 Easy +1 −0 updated 08/14/21, 10:21

Commit message

The method `FormEngineUtility::getIconHtml()` is used in various places,
e.g. when rendering icons of a SelectIcons field wizard. If many icons
are loaded, the rendering process may take some time, depending on the
user's internet connection. To improve the initial rendering speed, the
icons are now lazy loaded.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Guido Schmechel +1
    • Frank Nägler +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Frank Nägler +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Andreas Kienast uploaded patch set 1 08/13/21, 12:51

  2. Andreas Kienast uploaded patch set 2 08/13/21, 12:55

  3. Benjamin Kott voted on patch set 2 V +1 CR +1 08/13/21, 12:55

  4. Wouter Wolters voted on patch set 2 V +1 CR +1 08/13/21, 12:57

  5. Frank Nägler voted on patch set 2 V +1 CR +1 08/13/21, 12:58

  6. Guido Schmechel voted on patch set 2 CR +1 08/13/21, 13:01

  7. core-ci voted on patch set 1 V +1 08/13/21, 13:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14961

  8. core-ci voted on patch set 2 V -1 08/13/21, 13:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14962

  9. core-ci voted on patch set 2 V +1 08/13/21, 13:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14962

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 08/14/21, 10:21

  11. Andreas Kienast merged patch set 3 08/14/21, 10:21