70575[TASK] Remove "Non-XML text" validator from form editor
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Björn Jacob +1
-
Verified V +2 Done
- waldhacker +2
- Björn Jacob +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/core/Documentation/Changelog/master/Important-94876-RemoveNon-XMLTextValidatorFromFormEditor.rst2new+51 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+0 −3
- typo3/sysext/form/Configuration/Yaml/FormElements/Honeypot.yaml+0 −3
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+0 −3
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+0 −3
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+0 −3
- typo3/sysext/form/Documentation/I/Config/configuration/Index.rst+0 −18
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor/editors/900.rst+0 −3
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/AdvancedPassword/formEditor.rst+0 −3
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor/editors/900.rst+0 −3
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Password/formEditor.rst+0 −3
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor/editors/900.rst+0 −3
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Text/formEditor.rst+0 −3
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor/editors/900.rst+0 −3
- typo3/sysext/form/Documentation/I/Config/proto/formElements/formElementTypes/Textarea/formEditor.rst+0 −3
Review log 1927
Show 12 earlier messages
-
Mathias Brodala uploaded patch set 1 08/13/21, 13:14
-
core-ci voted on patch set 1 V +1 08/13/21, 13:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14968
-
Björn Jacob updated the commit message in patch set 2 08/13/21, 14:27
-
Björn Jacob commented on patch set 2 V +1 CR +1 08/13/21, 14:39
Tested different forms: * new form * existing form with "NON-XML text" validator Tested different cases: * added other attributs like "description" * added another validator Everything is fine, i.e. the "NON-XML text" validator is kept. -
core-ci voted on patch set 2 V +1 08/13/21, 14:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14981
-
Björn Jacob commented on patch set 2 V 0 CR -1 09/02/21, 07:29
On it. Adding an important rst. -
Björn Jacob uploaded patch set 3 09/02/21, 07:40
-
Björn Jacob updated the commit message in patch set 4 09/02/21, 07:41
-
Björn Jacob voted on patch set 4 V +1 CR +1 09/02/21, 07:46
-
core-ci voted on patch set 3 V +1 09/02/21, 07:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16049
-
core-ci voted on patch set 4 V +1 09/02/21, 08:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16050
-
Andreas Kienast commented on patch set 4 09/02/21, 08:32
Important-94876-RemoveNon-XMLTextValidatorFromFormEditor.rst:24How? ;) -
waldhacker commented on patch set 4 CR -1 09/02/21, 08:39
The patch removes too much configuration. I am about to push a new variant -
waldhacker uploaded patch set 5 09/02/21, 08:44
-
waldhacker commented on patch set 5 09/02/21, 08:47
Reply
If there are text validators in a form definition, the UI now (with the new patchset) keeps the corresponding validator editors. In new form definitions, the text validator can no longer be added by default. -
core-ci voted on patch set 5 V +1 09/02/21, 08:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16056
-
Björn Jacob commented on patch set 5 CR -1 09/02/21, 09:12
On it regarding rst. -
Björn Jacob uploaded patch set 6 09/02/21, 11:17
-
Björn Jacob voted on patch set 6 V +1 CR +1 09/02/21, 11:18
-
Björn Jacob commented on patch set 6 09/02/21, 11:18
Important-94876-RemoveNon-XMLTextValidatorFromFormEditor.rst:24ReplyDone -
core-ci voted on patch set 6 V -1 09/02/21, 11:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16068
-
core-ci commented on patch set 6 09/02/21, 11:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16068
-
Björn Jacob updated the commit message in patch set 7 09/02/21, 12:36
-
core-ci voted on patch set 7 V +1 09/02/21, 12:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16077
-
Björn Jacob voted on patch set 7 V +1 CR +1 09/02/21, 13:17
-
waldhacker voted on patch set 7 V +2 CR +2 09/02/21, 13:33
-
waldhacker merged patch set 8 09/02/21, 13:34