Review main Merged

70575[TASK] Remove "Non-XML text" validator from form editor

Mathias Brodala CR +2 V +2 Normal +51 −57 updated 09/02/21, 13:34

Commit message

The "Non-XML text" validator has been removed form the UI of the
form editor. Here's why:

* The validator has a very specific purpose since it is only useful for
  values which are output in an HTML context without escaping.
  By default, this is never the case in TYPO3 thanks to the automatic
  escaping in Fluid.
* The form editor is meant to be used by editors and integrators
  where the most usecases involve output of form values within TYPO3
  (website / mail). This validator does not serve any purpose then.
* The form editor should be uncluttered and stripped from too
  technical and complex concepts.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Björn Jacob +1
  • Verified V +2 Done
    • waldhacker +2
    • Björn Jacob +1
    • core-ci +1 CI

Issues 1

Files 15

Review log 1927

Show 12 earlier messages
  1. Mathias Brodala uploaded patch set 1 08/13/21, 13:14

  2. core-ci voted on patch set 1 V +1 08/13/21, 13:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14968

  1. Björn Jacob updated the commit message in patch set 2 08/13/21, 14:27

  2. Björn Jacob commented on patch set 2 V +1 CR +1 08/13/21, 14:39

    Tested different forms: * new form * existing form with "NON-XML text" validator Tested different cases: * added other attributs like "description" * added another validator Everything is fine, i.e. the "NON-XML text" validator is kept.
  3. core-ci voted on patch set 2 V +1 08/13/21, 14:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14981

  4. Björn Jacob commented on patch set 2 V 0 CR -1 09/02/21, 07:29

    On it. Adding an important rst.
  5. Björn Jacob uploaded patch set 3 09/02/21, 07:40

  6. Björn Jacob updated the commit message in patch set 4 09/02/21, 07:41

  7. Björn Jacob voted on patch set 4 V +1 CR +1 09/02/21, 07:46

  8. core-ci voted on patch set 3 V +1 09/02/21, 07:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16049

  9. core-ci voted on patch set 4 V +1 09/02/21, 08:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16050

  10. Andreas Kienast commented on patch set 4 09/02/21, 08:32

    Important-94876-RemoveNon-XMLTextValidatorFromFormEditor.rst:24

    How? ;)
  11. waldhacker commented on patch set 4 CR -1 09/02/21, 08:39

    The patch removes too much configuration. I am about to push a new variant
  12. waldhacker uploaded patch set 5 09/02/21, 08:44

  13. waldhacker commented on patch set 5 09/02/21, 08:47

    Reply

    If there are text validators in a form definition, the UI now (with the new patchset) keeps the corresponding validator editors. In new form definitions, the text validator can no longer be added by default.
  14. core-ci voted on patch set 5 V +1 09/02/21, 08:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16056

  15. Björn Jacob commented on patch set 5 CR -1 09/02/21, 09:12

    On it regarding rst.
  16. Björn Jacob uploaded patch set 6 09/02/21, 11:17

  17. Björn Jacob voted on patch set 6 V +1 CR +1 09/02/21, 11:18

  18. Björn Jacob commented on patch set 6 09/02/21, 11:18

    Important-94876-RemoveNon-XMLTextValidatorFromFormEditor.rst:24 Reply

    Done
  19. core-ci voted on patch set 6 V -1 09/02/21, 11:32 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16068

  20. core-ci commented on patch set 6 09/02/21, 11:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16068

  21. Björn Jacob updated the commit message in patch set 7 09/02/21, 12:36

  22. core-ci voted on patch set 7 V +1 09/02/21, 12:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16077

  23. Björn Jacob voted on patch set 7 V +1 CR +1 09/02/21, 13:17

  24. waldhacker voted on patch set 7 V +2 CR +2 09/02/21, 13:33

  25. waldhacker merged patch set 8 09/02/21, 13:34