Review main Merged

70576[TASK] Strictify tests part 4

Roman Büchler CR +2 V +2 Normal +36 −46 updated 08/14/21, 09:36

Commit message

This part handles:
- EXT:belog
- EXT:beuser

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1218

  1. Roman Büchler uploaded patch set 1 08/13/21, 13:40

  2. Wouter Wolters commented on patch set 1 08/13/21, 13:47

    BackendUserRepositoryTest should also be fixed. It is missing a return type

    ConstraintTest.php:29

    can be removed. The typehint is enough

    LogEntryTest.php:29

    can be removed. Typehint is enough

    LogEntryTest.php:68

    return type missing

    LogEntryTest.php:78

    return type missing

    BackendUserTest.php:29

    can be removed. Typehint is enough

    DemandTest.php:29

    can be removed. Typehint is enough
  3. Roman Büchler wrote 08/13/21, 13:53

    Topic set to unit-strict
  4. core-ci voted on patch set 1 V +1 08/13/21, 14:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14972

  5. Roman Büchler uploaded patch set 2 08/13/21, 14:11

  6. Roman Büchler uploaded patch set 3 08/13/21, 14:24

  7. core-ci voted on patch set 2 V +1 08/13/21, 14:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14974

  8. core-ci voted on patch set 3 V -1 08/13/21, 14:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14978

  9. core-ci commented on patch set 3 08/13/21, 15:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14978

  10. Christian Kuhn rebased onto patch set 4 08/13/21, 22:41

  11. Christian Kuhn commented on patch set 4 08/13/21, 22:42

    ConstraintTest.php:29 Reply

    Done

    LogEntryTest.php:29 Reply

    Done

    LogEntryTest.php:68 Reply

    Done

    LogEntryTest.php:78 Reply

    Done

    BackendUserTest.php:29 Reply

    Done

    DemandTest.php:29 Reply

    Done
  12. Christian Kuhn updated the commit message in patch set 5 08/13/21, 22:44

  13. core-ci voted on patch set 5 V +1 08/13/21, 22:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15033

  14. core-ci voted on patch set 4 V +1 08/13/21, 23:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15032

  15. Christian Kuhn voted on patch set 5 V +1 CR +1 08/13/21, 23:00

  16. Wouter Wolters voted on patch set 5 V +1 CR +1 08/14/21, 07:27

  17. Anja Leichsenring voted on patch set 5 V +2 CR +2 08/14/21, 09:35

  18. Anja Leichsenring merged patch set 6 08/14/21, 09:36