70576[TASK] Strictify tests part 4
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Wouter Wolters +1
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Wouter Wolters +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/belog/Tests/Unit/Domain/Model/ConstraintTest.php2+5 −8
- typo3/sysext/belog/Tests/Unit/Domain/Model/LogEntryTest.php6+6 −9
- typo3/sysext/beuser/Tests/Functional/ViewHelpers/MfaStatusViewHelperTest.php+3 −1
- typo3/sysext/beuser/Tests/Unit/Domain/Model/BackendUserTest.php2+9 −12
- typo3/sysext/beuser/Tests/Unit/Domain/Model/DemandTest.php2+12 −15
- typo3/sysext/beuser/Tests/Unit/Domain/Repository/BackendUserRepositoryTest.php+1 −1
Review log 1218
-
Roman Büchler uploaded patch set 1 08/13/21, 13:40
-
Wouter Wolters commented on patch set 1 08/13/21, 13:47
BackendUserRepositoryTest should also be fixed. It is missing a return typeConstraintTest.php:29can be removed. The typehint is enoughLogEntryTest.php:29can be removed. Typehint is enoughLogEntryTest.php:68return type missingLogEntryTest.php:78return type missingBackendUserTest.php:29can be removed. Typehint is enoughDemandTest.php:29can be removed. Typehint is enough -
Roman Büchler wrote 08/13/21, 13:53
Topic set to unit-strict -
core-ci voted on patch set 1 V +1 08/13/21, 14:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14972
-
Roman Büchler uploaded patch set 2 08/13/21, 14:11
-
Roman Büchler uploaded patch set 3 08/13/21, 14:24
-
core-ci voted on patch set 2 V +1 08/13/21, 14:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14974
-
core-ci voted on patch set 3 V -1 08/13/21, 14:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14978
-
core-ci commented on patch set 3 08/13/21, 15:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14978
-
Christian Kuhn rebased onto patch set 4 08/13/21, 22:41
-
Christian Kuhn commented on patch set 4 08/13/21, 22:42
ConstraintTest.php:29ReplyDoneLogEntryTest.php:29ReplyDoneLogEntryTest.php:68ReplyDoneLogEntryTest.php:78ReplyDoneBackendUserTest.php:29ReplyDoneDemandTest.php:29ReplyDone -
Christian Kuhn updated the commit message in patch set 5 08/13/21, 22:44
-
core-ci voted on patch set 5 V +1 08/13/21, 22:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15033
-
core-ci voted on patch set 4 V +1 08/13/21, 23:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15032
-
Christian Kuhn voted on patch set 5 V +1 CR +1 08/13/21, 23:00
-
Wouter Wolters voted on patch set 5 V +1 CR +1 08/14/21, 07:27
-
Anja Leichsenring voted on patch set 5 V +2 CR +2 08/14/21, 09:35
-
Anja Leichsenring merged patch set 6 08/14/21, 09:36