Review 10.4 Merged

70578[BUGFIX] Allow HTML node onclick events in generated frontend markup

Oliver Hader CR +2 V +2 Easy +32 −7 updated 08/16/21, 11:16

Commit message

`ContentObjectRenderer` and `AbstractMenuContentObject` are still relying
HTML event attribute `onclick` to open new client window instances,
which were (correctly) removed by HTML sanitizer.

In order to keep the functionality, exceptional declarations have been
added, and `vHWin=window.open(...)` substituted by `openPic(...)`.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 69

  1. Oliver Hader uploaded patch set 1 08/13/21, 14:27

  2. core-ci voted on patch set 1 V -1 08/13/21, 14:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14980

  3. Oliver Hader uploaded patch set 2 08/13/21, 15:23

  4. core-ci voted on patch set 2 V +1 08/13/21, 15:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14993

  5. Benni Mack updated the commit message in patch set 3 08/14/21, 11:17

  6. Benni Mack voted on patch set 3 V +1 CR +1 08/14/21, 11:19

  7. core-ci voted on patch set 3 V +1 08/14/21, 11:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15062

  8. Oliver Hader voted on patch set 3 V +2 CR +2 08/16/21, 11:16

  9. Oliver Hader merged patch set 4 08/16/21, 11:16