70585[TASK] Strictify UnitTests part 6
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- core-ci +1 CI
Issues 1
Files 59
- typo3/sysext/install/Tests/Unit/Controller/UpgradeControllerTest.php+7 −4
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Fixtures/CodeStatisticsFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ArrayDimensionMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ArrayGlobalMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ClassConstantMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ClassNameMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/ConstantMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/FunctionCallMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/InterfaceMethodChangedMatcherFixture.php+5 −5
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentDroppedMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentDroppedStaticMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentRequiredMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentRequiredStaticMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentUnusedMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodCallMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodCallStaticMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/PropertyProtectedMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/PropertyPublicMatcherFixture.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/AbstractCoreMatcherTest.php+5 −5
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayDimensionMatcherTest.php+2 −2
Show 39 more files
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayGlobalMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassConstantMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassNameMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstantMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/FunctionCallMatcherTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodAnnotationMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcherTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcherTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcherTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallStaticMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyAnnotationMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyExistsStaticMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyProtectedMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyPublicMatcherTest.php+3 −3
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/CodeStatisticsTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/GeneratorClassesResolverTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/MatcherFactoryTest.php+7 −7
- typo3/sysext/install/Tests/Unit/FolderStructure/AbstractNodeTest.php+62 −61
- typo3/sysext/install/Tests/Unit/FolderStructure/DefaultFactoryTest.php+1 −1
- typo3/sysext/install/Tests/Unit/FolderStructure/DirectoryNodeTest.php+30 −29
- typo3/sysext/install/Tests/Unit/FolderStructure/FileNodeTest.php+172 −171
- typo3/sysext/install/Tests/Unit/FolderStructure/LinkNodeTest.php+68 −67
- typo3/sysext/install/Tests/Unit/FolderStructure/RootNodeTest.php+31 −36
- typo3/sysext/install/Tests/Unit/FolderStructure/StructureFacadeTest.php+5 −4
- typo3/sysext/install/Tests/Unit/Service/ClearTableServiceTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Service/CoreUpdateServiceTest.php+10 −8
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+9 −5
- typo3/sysext/install/Tests/Unit/Service/EnableFileServiceTest.php+9 −8
- typo3/sysext/install/Tests/Unit/Service/SilentConfigurationUpgradeServiceTest.php+40 −37
- typo3/sysext/install/Tests/Unit/Service/Typo3tempFileServiceTest.php+5 −3
- typo3/sysext/install/Tests/Unit/SystemEnvironment/ServerResponse/ContentSecurityPolicyHeaderTest.php+1 −1
- typo3/sysext/install/Tests/Unit/Updates/RowUpdater/L18nDiffsourceToJsonMigrationTest.php+8 −5
- typo3/sysext/install/Tests/Unit/UpgradeAnalysis/DocumentationFileTest.php+15 −19
- typo3/sysext/install/Tests/Unit/FolderStructureTestCase.php+2 −2
Review log 69
-
Wouter Wolters uploaded patch set 1 08/13/21, 16:17
-
core-ci voted on patch set 1 V -1 08/13/21, 16:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14998
-
Wouter Wolters wrote 08/13/21, 17:31
Topic set to unit-strict -
core-ci voted on patch set 1 V +1 08/13/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14998
-
Anja Leichsenring voted on patch set 1 V +1 CR +1 08/14/21, 09:25
-
Tymoteusz Motylewski rebased onto patch set 2 08/29/21, 19:25
-
Tymoteusz Motylewski commented on patch set 2 V +2 CR +2 08/29/21, 19:26
rebased to verify it will not fail with recent testing framework changes, once it's green I'm merging it taking into account Anja's vote -
core-ci voted on patch set 2 V +1 08/29/21, 19:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15828
-
Tymoteusz Motylewski merged patch set 3 08/29/21, 19:41