Review main Merged

70585[TASK] Strictify UnitTests part 6

Wouter Wolters CR +2 V +2 Expert +554 −540 updated 08/29/21, 19:41

Commit message

The following core extensions are handled:

EXT:install

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • core-ci +1 CI

Issues 1

Files 59

Show 39 more files

Review log 69

  1. Wouter Wolters uploaded patch set 1 08/13/21, 16:17

  2. core-ci voted on patch set 1 V -1 08/13/21, 16:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14998

  3. Wouter Wolters wrote 08/13/21, 17:31

    Topic set to unit-strict
  4. core-ci voted on patch set 1 V +1 08/13/21, 17:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14998

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 08/14/21, 09:25

  6. Tymoteusz Motylewski rebased onto patch set 2 08/29/21, 19:25

  7. Tymoteusz Motylewski commented on patch set 2 V +2 CR +2 08/29/21, 19:26

    rebased to verify it will not fail with recent testing framework changes, once it's green I'm merging it taking into account Anja's vote
  8. core-ci voted on patch set 2 V +1 08/29/21, 19:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15828

  9. Tymoteusz Motylewski merged patch set 3 08/29/21, 19:41