70590[FEATURE] Use LinkResult to generated Typolinks in Frontend
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 15
- typo3/sysext/core/Documentation/Changelog/master/Feature-94889-AddResultOptionToTypolinkReturnLastParameter.rstnew+32 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-94889-LinkBuilderbuildNowReturnsArrayLinkResultInterface.rstnew+27 −0
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php1+69 −30
- typo3/sysext/frontend/Classes/Typolink/AbstractTypolinkBuilder.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php+2 −1
- typo3/sysext/frontend/Classes/Typolink/EmailLinkBuilder.php+7 −2
- typo3/sysext/frontend/Classes/Typolink/ExternalUrlLinkBuilder.php+10 −6
- typo3/sysext/frontend/Classes/Typolink/FileOrFolderLinkBuilder.php+4 −6
- typo3/sysext/frontend/Classes/Typolink/LegacyLinkBuilder.php+2 −2
- typo3/sysext/frontend/Classes/Typolink/LinkResult.phpnew+275 −0
- typo3/sysext/frontend/Classes/Typolink/LinkResultInterface.phpnew+44 −0
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+7 −2
- typo3/sysext/frontend/Classes/Typolink/TelephoneLinkBuilder.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+183 −9
- typo3/sysext/redirects/Classes/Service/RedirectService.php+9 −2
Review log 2539
Show 914 earlier messages
-
Tomek Woldański uploaded patch set 1 08/14/21, 10:50
-
core-ci voted on patch set 1 V -1 08/14/21, 10:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15055
-
Tomek Woldański uploaded patch set 2 08/14/21, 11:10
-
core-ci voted on patch set 2 V -1 08/14/21, 11:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15056
-
Tomek Woldański uploaded patch set 3 08/14/21, 11:32
-
Tymoteusz Motylewski commented on patch set 3 CR -1 08/14/21, 11:39
Please add documentation for this feature to the core changelog: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html?highlight=feature helper for geneating the .rst file: https://forger.typo3.com/utilities/rstUnresolved
[FEATURE], capital Add -
Tymoteusz Motylewski commented on patch set 3 08/14/21, 11:39
Unresolved
this is a feature so master only -
Tymoteusz Motylewski commented on patch set 3 08/14/21, 11:45
ContentObjectRenderer.php:4828Unresolvedwouldnt 'linkData' be a better name here? what do you think? -
core-ci voted on patch set 3 V +1 08/14/21, 11:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15065
-
Tomek Woldański uploaded patch set 4 08/23/21, 15:41
-
core-ci voted on patch set 4 V -1 08/23/21, 16:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15417
-
Tomek Woldański rebased onto patch set 5 08/24/21, 12:27
-
core-ci voted on patch set 5 V +1 08/24/21, 12:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15503
-
Benni Mack uploaded patch set 6 09/01/21, 12:52
-
core-ci voted on patch set 6 V -1 09/01/21, 14:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16009
-
Tomek Woldański uploaded patch set 7 09/02/21, 15:13
-
core-ci voted on patch set 7 V -1 09/02/21, 15:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16103
-
Tomek Woldański uploaded patch set 8 09/02/21, 15:25
-
core-ci voted on patch set 8 V -1 09/02/21, 15:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16104
-
Benni Mack uploaded patch set 9 09/02/21, 17:18
-
Benni Mack uploaded patch set 10 09/02/21, 17:25
-
Nikita Hovratov commented on patch set 8 CR -1 09/02/21, 17:26
This feature is breaking. The LinkBuilders all of a sudden return now an object. They are considered public API, so we need a deprecation strategy for them. Maybe by extending ArrayAccess: https://www.php.net/manual/en/class.arrayaccess.php Such an access should then trigger a deprecation error. To further improve the API we can also add a factory/registry class for LinkBuilders and register them via DI. This would be a very similar treatment like with softrefs parsers recently: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70177 -
core-ci voted on patch set 9 V -1 09/02/21, 17:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16117
-
Benni Mack commented on patch set 10 09/02/21, 17:38
Reply
good point. ArrayAccess indeed seems like a good solution. I'm waiting for the next test run, and then implement ArrayAccess. -
core-ci voted on patch set 10 V -1 09/02/21, 17:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16119
-
Benni Mack uploaded patch set 11 09/02/21, 18:00
-
core-ci voted on patch set 11 V -1 09/02/21, 18:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16121
-
Benni Mack uploaded patch set 12 09/02/21, 18:19
-
core-ci voted on patch set 12 V +1 09/02/21, 18:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16122
-
Benni Mack commented on patch set 13 09/02/21, 18:42
Published edit on patch set 12. -
core-ci voted on patch set 13 V +1 09/02/21, 18:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16123
-
Oliver Hader uploaded patch set 14 09/02/21, 20:17
-
core-ci voted on patch set 14 V +1 09/02/21, 20:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16130
-
Benni Mack voted on patch set 14 V +1 CR +1 09/02/21, 20:46
-
Oliver Hader voted on patch set 14 V +2 CR +2 09/02/21, 20:58
-
Oliver Hader merged patch set 15 09/02/21, 20:59
-
Nikita Hovratov commented on patch set 15 09/03/21, 07:39
Reply
Done -
Oliver Hader commented on patch set 15 04/19/22, 11:36
Hi folks, concerning https://review.typo3.org/c/Packages/TYPO3.CMS/+/72999 I stumbled over this change again. What's the reason again we introduced `typolink.returnLast = result` back then? Would it be possible to use (an intermediate) `public function typolinkResult(...): ?LinkResultInterface` instead? -
Oliver Hader commented on patch set 15 04/19/22, 11:38
Reply
Guess I found it: https://github.com/search?q=org%3ATYPO3-Headless+returnLast&type=code