Review main Abandoned

70591[TASK][WIP] Calculate code coverage for unit and functional tests

Łukasz Uznański CR 0 V 0 Easy +42 −1 updated 11/05/21, 12:48

Commit message

Add option to calculate code coverage for unit and functional tests
locally, merge results and present in CI.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 68

  1. Łukasz Uznański uploaded patch set 1 08/14/21, 11:17

  2. Łukasz Uznański uploaded patch set 2 08/14/21, 11:18

  3. Christian Kuhn commented on patch set 2 08/14/21, 11:23

    this could be solved already with '-e "--coverage-html=coverage-unit"', can't it?
  4. core-ci voted on patch set 1 V +1 08/14/21, 11:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15059

  5. core-ci voted on patch set 2 V +1 08/14/21, 11:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15063

  6. Wouter Wolters commented on patch set 2 CR -1 08/14/21, 17:26

    I suggest to use pcov for code coverage. It is much quicker than using xdebug. https://github.com/krakjoe/pcov
  7. Christian Kuhn commented on patch set 2 11/05/21, 12:48

    Hey. I hope it's ok to abandon this for now: We don't have coverage reports within gitlab at the moment and I personally think these metrics are of limited use (that's at least my impression whenever I looked at usages in the past). If anyone wants to generate coverage stats with runTests.sh, that should be possible using the -e option already. If coverage really materializes and devs start creating patches based on that data, we can always reconsider and revive the patch or create a new one.
  8. Christian Kuhn abandoned the change 11/05/21, 12:48