70591[TASK][WIP] Calculate code coverage for unit and functional tests
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 68
-
Łukasz Uznański uploaded patch set 1 08/14/21, 11:17
-
Łukasz Uznański uploaded patch set 2 08/14/21, 11:18
-
Christian Kuhn commented on patch set 2 08/14/21, 11:23
this could be solved already with '-e "--coverage-html=coverage-unit"', can't it? -
core-ci voted on patch set 1 V +1 08/14/21, 11:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15059
-
core-ci voted on patch set 2 V +1 08/14/21, 11:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15063
-
Wouter Wolters commented on patch set 2 CR -1 08/14/21, 17:26
I suggest to use pcov for code coverage. It is much quicker than using xdebug. https://github.com/krakjoe/pcov -
Christian Kuhn commented on patch set 2 11/05/21, 12:48
Hey. I hope it's ok to abandon this for now: We don't have coverage reports within gitlab at the moment and I personally think these metrics are of limited use (that's at least my impression whenever I looked at usages in the past). If anyone wants to generate coverage stats with runTests.sh, that should be possible using the -e option already. If coverage really materializes and devs start creating patches based on that data, we can always reconsider and revive the patch or create a new one. -
Christian Kuhn abandoned the change 11/05/21, 12:48