Review main Merged

70592[BUGFIX] Fix various context menu visibility issues

Andreas Kienast CR +2 V +2 Normal +33 −57 updated 08/23/21, 19:18

Commit message

The context menu skeleton is partially visible for a very short time,
before its items are rendered and event listeners are attached. This is
revealed by some flaky acceptance tests and was previously workarounded
by an additional ->wait() call in the tests. The context menu stays
hidden now until everything is set up and the workaround in the AC tests
is removed again.

The context menu gets hidden after 500ms once the user moved the mouse
out of its boundaries. However, that timeout was never reset which closed
another context menu that might have opened within that 500ms time span.
To circument this issue, such timeouts are now monitored and cleared
again once a new context menu is requested.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Alexander Nitsche +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • Christian Kuhn +1
    • Alexander Nitsche +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1521

  1. Andreas Kienast uploaded patch set 1 08/14/21, 13:19

  2. core-ci voted on patch set 1 V +1 08/14/21, 13:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15081

  3. Andreas Kienast uploaded patch set 2 08/14/21, 14:13

  4. Andreas Kienast uploaded patch set 3 08/14/21, 14:33

  5. core-ci voted on patch set 2 V +1 08/14/21, 14:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15084

  6. core-ci voted on patch set 3 V -1 08/14/21, 14:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15087

  7. core-ci voted on patch set 3 V +1 08/14/21, 15:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15087

  8. Alexander Nitsche commented on patch set 3 V -1 08/14/21, 16:27

    What seems to fail in a reproducable way is: (1) Module "List" > any page in page tree > content frame > click on any table icon > click on context menu "More options .." > click on another table icon > click on context menu "More options .." > click somewhere in main frame > Only the "more" overlay closes instead of both overlays.
  9. Alexander Nitsche commented on patch set 3 08/14/21, 16:33

    Unresolved

    (2) Open any context menu > click on "More options .." > mouse over a menu item of the submenu while leaving the area of the mainmenu of the context menu > the mainmenu disappears while the submenu still shows: Should the mainmenu also be visible until the user left both areas or clicked a menu item?
  10. Alexander Nitsche commented on patch set 3 08/14/21, 16:42

    Reply

    It seems to be more the mouse movement speed: When having clicked on "More options .." and moving the cursor quite fast away from the menu area, either no or one menu layer gets closed only - sometimes ..
  11. Andreas Kienast commented on patch set 3 08/15/21, 14:09

    Reply Unresolved

    I was able to reproduce both issues. The latter is reproducible to me if the menu is opened in the page tree and overlaps the iframe and the mouse is moved within the iframe. It seems the JavaScript cannot handle this case.
  12. Andreas Kienast uploaded patch set 4 08/15/21, 14:09

  13. core-ci voted on patch set 4 V -1 08/15/21, 14:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15117

  14. Andreas Kienast commented on patch set 4 08/15/21, 15:36

    The AC failure looks like a timeout when clicking the root page's title to list its contents.
  15. core-ci voted on patch set 4 V +1 08/15/21, 15:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15117

  16. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/23/21, 17:11

  17. Wouter Wolters voted on patch set 4 CR +1 08/23/21, 18:31

  18. Christian Kuhn voted on patch set 4 V +1 CR +1 08/23/21, 19:12

  19. Alexander Nitsche voted on patch set 4 V +1 CR +1 08/23/21, 19:13

  20. Andreas Kienast voted on patch set 4 V +2 CR +2 08/23/21, 19:18

  21. Andreas Kienast merged patch set 5 08/23/21, 19:18