70593[TASK] Strictify UnitTests part 5 - EXT:core
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 381
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/CompareUserCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListGroupCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListUserCest.php+9 −9
- typo3/sysext/core/Tests/Acceptance/Application/Dashboard/DashboardModuleCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/DbCheck/DbCheckModuleCest.php+6 −6
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/GetExtensionsCest.php+5 −5
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/InstalledExtensionsCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/FileList/AbstractFileCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileClipboardCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileMetaDataCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileOperationsCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Application/FileList/FileStorageTreeFilterCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/AbstractElementsBasicCest.php+7 −7
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/CategoryTreeCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+9 −9
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputEvalCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputRangeCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputSimpleCest.php+3 −3
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputTextTableCest.php+7 −7
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsGroupCest.php+5 −5
Show 361 more files
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/FalMetadataCest.php+4 −4
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/Inline1nCest.php+8 −30
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/InlineFalCest.php+4 −19
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/NullPlaceholderCest.php+2 −8
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/ContentElementsCest.php+1 −7
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FormFrameworkCest.php+1 −10
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/FrontendLoginCest.php+1 −10
- typo3/sysext/core/Tests/Acceptance/Application/Frontend/IndexedSearchCest.php+1 −10
- typo3/sysext/core/Tests/Acceptance/Application/General/ModuleMenuCest.php+3 −9
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ExportCest.php+13 −30
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/ImportCest.php+24 −52
- typo3/sysext/core/Tests/Acceptance/Application/Impexp/UsersCest.php+13 −21
- typo3/sysext/core/Tests/Acceptance/Application/IndexedSearch/IndexedSearchModuleCest.php+2 −5
- typo3/sysext/core/Tests/Acceptance/Application/Info/InfoModuleCest.php+5 −21
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/AbstractCest.php+5 −6
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/EnvironmentCest.php+2 −3
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/LoginCest.php+0 −3
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/MaintenanceCest.php+9 −17
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/SettingsCest.php+8 −21
- typo3/sysext/core/Tests/Acceptance/Application/InstallTool/UpgradeCest.php+8 −30
- typo3/sysext/core/Tests/Acceptance/Application/Login/BackendLoginCest.php+6 −20
- typo3/sysext/core/Tests/Acceptance/Application/Page/AddPageInPageModuleCest.php+3 −8
- typo3/sysext/core/Tests/Acceptance/Application/Page/PageModuleCest.php+3 −18
- typo3/sysext/core/Tests/Acceptance/Application/PageTree/KeyboardAccess/SelectPagetreeWithKeyboardCest.php+7 −21
- typo3/sysext/core/Tests/Acceptance/Application/PageTree/PageTreeFilterCest.php+11 −26
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/RecordDownloadCest.php+1 −9
- typo3/sysext/core/Tests/Acceptance/Application/RecordList/SysNoteCest.php+2 −9
- typo3/sysext/core/Tests/Acceptance/Application/Redirect/RedirectModuleCest.php+3 −17
- typo3/sysext/core/Tests/Acceptance/Application/Report/ReportModuleCest.php+3 −12
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+9 −29
- typo3/sysext/core/Tests/Acceptance/Application/Site/SiteModuleCest.php+4 −21
- typo3/sysext/core/Tests/Acceptance/Application/Template/TemplateCest.php+3 −12
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/BookmarkCest.php+11 −34
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/FlushCest.php+4 −13
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/HelpCest.php+5 −20
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/LogoCest.php+2 −8
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/ModuleMenuButtonCest.php+3 −12
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/NavigationComponentTreeCest.php+3 −12
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/SearchCest.php+5 −17
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/SetupCest.php+4 −13
- typo3/sysext/core/Tests/Acceptance/Application/Topbar/UsernameOnAvatarCest.php+1 −3
- typo3/sysext/core/Tests/Acceptance/Application/Workspace/WorkspaceModuleCest.php+3 −13
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/BlankPageCest.php+2 −1
- typo3/sysext/core/Tests/Acceptance/Install/Mysql/IntroductionPackageCest.php+2 −1
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Postgresql/IntroductionPackageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/BlankPageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Install/Sqlite/IntroductionPackageCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Extension/BackendCoreEnvironment.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Support/Helper/ModalDialog.php+2 −2
- typo3/sysext/core/Tests/Unit/Authentication/Mfa/Provider/RecoveryCodesTest.php2+1 −1
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Authentication/AuthenticationServiceTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Authentication/BackendUserAuthenticationTest.php+5 −6
- typo3/sysext/core/Tests/Unit/Authentication/IpLockerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/Fixtures/ConcreteBackendFixture.php+8 −11
- typo3/sysext/core/Tests/Unit/Cache/Backend/AbstractBackendTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/ApcuBackendTest.php+16 −16
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/MockBackend.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/TransientMemoryBackendTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Cache/Backend/Typo3DatabaseBackendTest.php+18 −16
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/BackendFixture.php+4 −4
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/BackendInitializeObjectFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/FrontendFixture.php+7 −10
- typo3/sysext/core/Tests/Unit/Cache/Fixtures/FrontendInitializeObjectFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Cache/Frontend/AbstractFrontendTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Cache/Frontend/PhpFrontendTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Cache/Frontend/VariableFrontendTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Cache/CacheManagerTest.php+27 −25
- typo3/sysext/core/Tests/Unit/Category/Collection/CategoryCollectionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Charset/CharsetConverterTest.php+13 −13
- typo3/sysext/core/Tests/Unit/Command/SendEmailCommandTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Configuration/FlexForm/FlexFormToolsTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Configuration/Loader/PageTsConfigLoaderTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Configuration/Loader/YamlFileLoaderTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Configuration/Parser/PageTsConfigParserTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/Fixtures/ConditionMatcherUserFuncs.php+9 −9
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php2+5 −6
- typo3/sysext/core/Tests/Unit/Configuration/ExtensionConfigurationTest.php+9 −7
- typo3/sysext/core/Tests/Unit/Configuration/FeaturesTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Configuration/RichtextTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php4+5 −7
- typo3/sysext/core/Tests/Unit/Console/CommandRegistryTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Context/ContextTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Context/DateTimeAspectTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Context/UserAspectTest.php+12 −12
- typo3/sysext/core/Tests/Unit/Context/VisibilityAspectTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Context/WorkspaceAspectTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Core/ApplicationContextTest.php+7 −9
- typo3/sysext/core/Tests/Unit/Core/ClassLoadingInformationGeneratorTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Core/SystemEnvironmentBuilderTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2idPasswordHashTest.php+15 −18
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Argon2iPasswordHashTest.php2+15 −18
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BcryptPasswordHashTest.php2+16 −19
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/BlowfishPasswordHashTest.php+15 −15
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Md5PasswordHashTest.php+12 −12
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/PasswordHashFactoryTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/Pbkdf2PasswordHashTest.php+16 −16
- typo3/sysext/core/Tests/Unit/Crypto/PasswordHashing/PhpassPasswordHashTest.php+15 −15
- typo3/sysext/core/Tests/Unit/Crypto/RandomTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Mocks/MockKeywordList.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Mocks/MockPlatform.php4+13 −13
- typo3/sysext/core/Tests/Unit/Database/Platform/PlatformInformationTest.php+7 −5
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php2+53 −59
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/AbstractRestrictionContainerTest.php+8 −6
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/AbstractRestrictionTestCase.php+4 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/BackendWorkspaceRestrictionTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DefaultRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/DeletedRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/EndTimeRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendGroupRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/HiddenRestrictionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/LimitToTablesRestrictionContainerTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/PagePermissionRestrictionTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/RootLevelRestrictionTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/StartTimeRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/WorkspaceRestrictionTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Database/Query/BulkInsertTest.php2+16 −22
- typo3/sysext/core/Tests/Unit/Database/Query/QueryBuilderTest.php2+12 −16
- typo3/sysext/core/Tests/Unit/Database/Query/QueryHelperTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/EventListener/SchemaColumnDefinitionListenerTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypeAttributes/CharacterTypeAttributesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypeAttributes/EnumerationTypeAttributesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypeAttributes/NumericTypeAttributesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/BinaryDataTypeTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/BitDataTypeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/BlobTypesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/CharDataTypeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/DateTimeTypesTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/EnumDataTypeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/FixedPointTypesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/FloatingPointTypesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/IntegerTypesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/JsonDataTypeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/SetDataTypeTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/DataTypes/TextTypesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/AbstractDataTypeBaseTestCase.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ColumnDefinitionAttributesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ColumnDefinitionItemTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/CreateTableFragmentTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ForeignKeyDefinitionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/IndexDefinitionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/ReferenceDefinitionTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableBuilderTest.php2+22 −23
- typo3/sysext/core/Tests/Unit/Database/Schema/Parser/TableOptionsTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/Schema/Types/EnumTypeTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/Types/SetTypeTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php+6 −7
- typo3/sysext/core/Tests/Unit/Database/Schema/DefaultTcaSchemaTest.php2+39 −46
- typo3/sysext/core/Tests/Unit/Database/Schema/SqlReaderTest.php+9 −7
- typo3/sysext/core/Tests/Unit/Database/ConnectionPoolTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Database/ConnectionTest.php2+23 −27
- typo3/sysext/core/Tests/Unit/Database/RelationHandlerTest.php+3 −3
- typo3/sysext/core/Tests/Unit/DataHandling/Fixtures/AllowAccessHookFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/DataHandling/Localization/StateTest.php+3 −3
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php8+41 −40
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php+9 −9
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestRegistryServiceProvider.php+2 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestServiceProvider.php+3 −3
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestServiceProviderFactoryOverride.php+2 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestServiceProviderOverride.php+2 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestServiceProviderOverride2.php+2 −2
- typo3/sysext/core/Tests/Unit/DependencyInjection/Fixtures/TestStatefulServiceProvider.php+3 −3
- typo3/sysext/core/Tests/Unit/DependencyInjection/FailsafeContainerTest.php2+4 −5
- typo3/sysext/core/Tests/Unit/DependencyInjection/ListenerProviderPassTest.php+4 −4
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderCompilationPassTest.php2+12 −10
- typo3/sysext/core/Tests/Unit/DependencyInjection/ServiceProviderRegistryTest.php+13 −11
- typo3/sysext/core/Tests/Unit/Domain/Repository/PageRepositoryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Error/DebugExceptionHandlerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+6 −4
- typo3/sysext/core/Tests/Unit/EventDispatcher/EventDispatcherTest.php2+10 −12
- typo3/sysext/core/Tests/Unit/EventDispatcher/ListenerProviderTest.php2+11 −13
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+7 −5
- typo3/sysext/core/Tests/Unit/FormProtection/Fixtures/FormProtectionTesting.php+2 −2
- typo3/sysext/core/Tests/Unit/FormProtection/AbstractFormProtectionTest.php2+1 −4
- typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php+5 −5
- typo3/sysext/core/Tests/Unit/FormProtection/FormProtectionFactoryTest.php+9 −9
- typo3/sysext/core/Tests/Unit/FormProtection/InstallToolFormProtectionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Hooks/TcaItemsProcessorFunctionsTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Html/HtmlParserTest.php2+1 −4
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+15 −15
- typo3/sysext/core/Tests/Unit/Http/Fixtures/MiddlewareFixture.php+1 −4
- typo3/sysext/core/Tests/Unit/Http/Security/ReferrerEnforcerTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Http/ApplicationTypeTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Http/ClientTest.php+2 −1
- typo3/sysext/core/Tests/Unit/Http/MessageTest.php2+26 −33
- typo3/sysext/core/Tests/Unit/Http/MiddlewareDispatcherTest.php+10 −8
- typo3/sysext/core/Tests/Unit/Http/MiddlewareStackResolverTest.php+7 −5
- typo3/sysext/core/Tests/Unit/Http/NormalizedParamsTest.php+28 −28
- typo3/sysext/core/Tests/Unit/Http/RedirectResponseTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Http/RequestFactoryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Http/RequestTest.php2+40 −43
- typo3/sysext/core/Tests/Unit/Http/ResponseFactoryTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Http/ResponseTest.php2+17 −20
- typo3/sysext/core/Tests/Unit/Http/ServerRequestFactoryTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Http/ServerRequestTest.php2+13 −16
- typo3/sysext/core/Tests/Unit/Http/StreamFactoryTest.php+12 −12
- typo3/sysext/core/Tests/Unit/Http/StreamTest.php2+40 −43
- typo3/sysext/core/Tests/Unit/Http/UploadedFileFactoryTest.php+8 −6
- typo3/sysext/core/Tests/Unit/Http/UploadedFileTest.php+17 −17
- typo3/sysext/core/Tests/Unit/Http/UriFactoryTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Http/UriTest.php+55 −55
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/BitmapIconProviderTest.php2+5 −8
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/FontawesomeIconProviderTest.php2+7 −8
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgIconProviderTest.php2+5 −8
- typo3/sysext/core/Tests/Unit/Imaging/IconProvider/SvgSpriteIconProviderTest.php2+1 −4
- typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/CropVariantCollectionTest.php+4 −7
- typo3/sysext/core/Tests/Unit/Imaging/ImageManipulation/CropVariantTest.php+4 −7
- typo3/sysext/core/Tests/Unit/Imaging/DimensionTest.php2+5 −16
- typo3/sysext/core/Tests/Unit/Imaging/GraphicalFunctionsTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Imaging/IconFactoryTest.php6+40 −50
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+21 −19
- typo3/sysext/core/Tests/Unit/Imaging/IconTest.php2+10 −19
- typo3/sysext/core/Tests/Unit/LinkHandling/EmailLinkHandlerTest.php+7 −7
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+4 −4
- typo3/sysext/core/Tests/Unit/LinkHandling/LinkServiceTest.php4+3 −13
- typo3/sysext/core/Tests/Unit/LinkHandling/PageLinkHandlerTest.php4+3 −13
- typo3/sysext/core/Tests/Unit/LinkHandling/RecordLinkHandlerTest.php+3 −3
- typo3/sysext/core/Tests/Unit/LinkHandling/TelephoneLinkHandlerTest.php4+2 −11
- typo3/sysext/core/Tests/Unit/LinkHandling/UrlLinkHandlerTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php+8 −9
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Localization/TcaSystemLanguageCollectorTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Locking/Fixtures/DummyLock.php+6 −6
- typo3/sysext/core/Tests/Unit/Locking/FileLockStrategyTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Locking/LockFactoryTest.php+9 −7
- typo3/sysext/core/Tests/Unit/Locking/SemaphoreLockStrategyTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Locking/SimpleLockStrategyTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Log/Fixtures/ProcessorFixture.php+3 −3
- typo3/sysext/core/Tests/Unit/Log/Fixtures/WriterFailing.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/Fixtures/WriterFixture.php+1 −4
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractMemoryTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Log/Processor/AbstractProcessorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Log/Processor/IntrospectionProcessorTest.php+9 −10
- typo3/sysext/core/Tests/Unit/Log/Processor/MemoryPeakUsageProcessorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Processor/MemoryUsageProcessorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Processor/WebProcessorTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/AbstractWriterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/DatabaseWriterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Log/Writer/FileWriterTest.php+9 −16
- typo3/sysext/core/Tests/Unit/Log/LoggerTest.php+13 −13
- typo3/sysext/core/Tests/Unit/Log/LogLevelTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Log/LogManagerTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Log/LogRecordTest.php+13 −13
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeInvalidSpoolFixture.php+2 −2
- typo3/sysext/core/Tests/Unit/Mail/Fixtures/FakeValidSpoolFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Mail/FileSpoolTest.php+3 −6
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php+14 −12
- typo3/sysext/core/Tests/Unit/Mail/MailMessageTest.php+2 −4
- typo3/sysext/core/Tests/Unit/Mail/TransportFactoryTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/BootstrapRendererTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/ListRendererTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Messaging/Renderer/PlaintextRendererTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageQueueTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageRendererResolverTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageServiceTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Messaging/FlashMessageTest.php+1 −1
- typo3/sysext/core/Tests/Unit/MetaTag/GenericMetaTagManagerTest.php+6 −6
- typo3/sysext/core/Tests/Unit/MetaTag/MetaTagManagerRegistryTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Package/AbstractServiceProviderTest.php+9 −7
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+12 −6
- typo3/sysext/core/Tests/Unit/Package/PackageTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Page/AssetCollectorTest.php+1 −4
- typo3/sysext/core/Tests/Unit/Page/AssetRendererTest.php+2 −9
- typo3/sysext/core/Tests/Unit/Page/PageRendererTest.php+18 −16
- typo3/sysext/core/Tests/Unit/Pagination/ArrayPaginatorTest.php+8 −11
- typo3/sysext/core/Tests/Unit/Pagination/SimplePaginationTest.php+5 −4
- typo3/sysext/core/Tests/Unit/Preparations/TcaPreparationTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Resource/Collection/FileCollectionRegistryTest.php+13 −16
- typo3/sysext/core/Tests/Unit/Resource/Driver/Fixtures/LocalDriverFilenameFilter.php+7 −2
- typo3/sysext/core/Tests/Unit/Resource/Driver/AbstractDriverTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/Driver/AbstractHierarchicalFilesystemDriverTest.php+7 −5
- typo3/sysext/core/Tests/Unit/Resource/Driver/DriverRegistryTest.php+1 −4
- typo3/sysext/core/Tests/Unit/Resource/Driver/LocalDriverTest.php+19 −29
- typo3/sysext/core/Tests/Unit/Resource/Filter/FileNameFilterTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Resource/Index/ExtractorRegistryTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/OnlineMedia/Helpers/VimeoHelperTest.php+6 −7
- typo3/sysext/core/Tests/Unit/Resource/Processing/LocalPreviewHelperTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Resource/Processing/ProcessorRegistryTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Resource/Rendering/AudioTagRendererTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php+9 −8
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VimeoRendererTest.php+39 −38
- typo3/sysext/core/Tests/Unit/Resource/Rendering/YouTubeRendererTest.php+40 −39
- typo3/sysext/core/Tests/Unit/Resource/Repository/AbstractRepositoryTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest/Fixtures/TestableResourceCompressor.php+5 −2
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/PlainTextExtractorTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Resource/TextExtraction/TextExtractorRegistryTest.php+5 −4
- typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php+7 −5
- typo3/sysext/core/Tests/Unit/Resource/BaseTestCase.php+13 −18
- typo3/sysext/core/Tests/Unit/Resource/FileReferenceTest.php+15 −9
- typo3/sysext/core/Tests/Unit/Resource/FolderTest.php+10 −10
- typo3/sysext/core/Tests/Unit/Resource/MetaDataAspectTest.php+6 −3
- typo3/sysext/core/Tests/Unit/Resource/ProcessedFileTest.php+11 −12
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorIntegrationTest.php+3 −14
- typo3/sysext/core/Tests/Unit/Resource/ResourceCompressorTest.php+7 −5
- typo3/sysext/core/Tests/Unit/Resource/ResourceFactoryTest.php+5 −8
- typo3/sysext/core/Tests/Unit/Resource/ResourceStorageTest.php+22 −19
- typo3/sysext/core/Tests/Unit/Resource/StorageRepositoryTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Routing/Aspect/AspectFactoryTest.php+9 −17
- typo3/sysext/core/Tests/Unit/Routing/Enhancer/VariableProcessorTest.php+6 −9
- typo3/sysext/core/Tests/Unit/Routing/PageRouterTest.php+4 −2
- typo3/sysext/core/Tests/Unit/Routing/SiteMatcherTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Service/DependencyOrderingServiceTest.php+11 −11
- typo3/sysext/core/Tests/Unit/Service/FlexFormServiceTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Service/MarkerBasedTemplateServiceTest.php+4 −5
- typo3/sysext/core/Tests/Unit/Session/Backend/DatabaseSessionBackendTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Session/Backend/RedisSessionBackendTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Session/SessionManagerTest.php+7 −5
- typo3/sysext/core/Tests/Unit/Session/UserSessionManagerTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteLanguageTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Site/Entity/SiteTest.php+10 −9
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/Fixtures/TreeDataProviderFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/Fixtures/TreeDataProviderWithConfigurationFixture.php+1 −1
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/DatabaseTreeDataProviderTest.php+14 −12
- typo3/sysext/core/Tests/Unit/Tree/TableConfiguration/TreeDataProviderFactoryTest.php+3 −1
- typo3/sysext/core/Tests/Unit/Type/File/ImageInfoTest.php+6 −4
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/CompleteEnumeration.php+4 −4
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/DuplicateConstantValueEnumeration.php+2 −2
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/InvalidConstantEnumeration.php+1 −1
- typo3/sysext/core/Tests/Unit/Type/Fixture/Enumeration/MissingDefaultEnumeration.php+1 −1
- typo3/sysext/core/Tests/Unit/Type/BitSetTest.php+2 −2
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+3 −1
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php+7 −10
- typo3/sysext/core/Tests/Unit/Utility/AccessibleProxies/ExtensionManagementUtilityAccessibleProxy.php+22 −10
- typo3/sysext/core/Tests/Unit/Utility/File/ExtendedFileUtilityTest.php+5 −3
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/GeneralUtilityFilesystemFixture.php+4 −5
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/GeneralUtilityFixture.php+5 −8
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/MathUtilityTestClassWithStringRepresentationFixture.php+3 −3
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/StringValue.php+1 −1
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/TwoParametersConstructorFixture.php+3 −10
- typo3/sysext/core/Tests/Unit/Utility/Fixtures/VersionNumberUtilityFixture.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php+95 −94
- typo3/sysext/core/Tests/Unit/Utility/ClassNamingUtilityTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Utility/CommandUtilityTest.php+3 −2
- typo3/sysext/core/Tests/Unit/Utility/CsvUtilityTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Utility/DebugUtilityTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Utility/ExtensionManagementUtilityTest.php+78 −79
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+245 −236
- typo3/sysext/core/Tests/Unit/Utility/HttpUtilityTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Utility/IpAnonymizationUtilityTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/MailUtilityTest.php+8 −8
- typo3/sysext/core/Tests/Unit/Utility/MathUtilityTest.php+23 −23
- typo3/sysext/core/Tests/Unit/Utility/PathUtilityTest.php+8 −7
- typo3/sysext/core/Tests/Unit/Utility/ResourceUtilityTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+5 −2
- typo3/sysext/core/Tests/Unit/Utility/StringUtilityTest.php+16 −16
- typo3/sysext/core/Tests/Unit/Utility/VersionNumberUtilityTest.php+4 −4
- typo3/sysext/core/Tests/Unit/RegistryTest.php+6 −6
- typo3/sysext/core/Tests/UnitDeprecated/Cache/Backend/PdoBackendTest.php+17 −17
- typo3/sysext/core/Tests/UnitDeprecated/Cache/Backend/WincacheBackendTest.php+16 −16
- typo3/sysext/core/Tests/UnitDeprecated/Category/CategoryRegistryTest.php+2 −8
- typo3/sysext/core/Tests/UnitDeprecated/Compatibility/Fixtures/PublicMethodDeprecationTraitTextFixture.php+1 −1
- typo3/sysext/core/Tests/UnitDeprecated/Compatibility/PublicPropertyDeprecationTraitTest.php+4 −4
- typo3/sysext/core/Tests/UnitDeprecated/Database/SoftReferenceIndexTest.php+10 −9
Review log 3458
Show 1833 earlier messages
-
Roman Büchler uploaded patch set 1 08/14/21, 18:12
-
core-ci voted on patch set 1 V -1 08/14/21, 18:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15104
-
Roman Büchler uploaded patch set 2 08/14/21, 18:30
-
core-ci voted on patch set 2 V -1 08/14/21, 18:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15106
-
Roman Büchler uploaded patch set 3 08/15/21, 08:47
-
Roman Büchler wrote 08/15/21, 08:51
Topic set to unit-strict -
core-ci voted on patch set 3 V -1 08/15/21, 09:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15113
-
Roman Büchler uploaded patch set 4 08/16/21, 04:33
-
core-ci voted on patch set 4 V -1 08/16/21, 04:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15141
-
Roman Büchler uploaded patch set 5 08/16/21, 06:07
-
core-ci voted on patch set 5 V -1 08/16/21, 06:26 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15143
-
Roman Büchler uploaded patch set 6 08/16/21, 07:48
-
core-ci voted on patch set 6 V -1 08/16/21, 07:51 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15147
-
Roman Büchler uploaded patch set 7 08/16/21, 12:17
-
core-ci voted on patch set 7 V -1 08/16/21, 14:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15175
-
Roman Büchler uploaded patch set 8 08/16/21, 14:49
-
core-ci voted on patch set 8 V -1 08/16/21, 16:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15187
-
Wouter Wolters commented on patch set 8 08/16/21, 17:17
AbstractActionTestCase.php:108Unresolvedthis should return void I thinkCheckboxElementItems.php:29Unresolvedthis function does not return an array. -
Roman Büchler uploaded patch set 9 08/16/21, 17:27
-
Roman Büchler uploaded patch set 10 08/16/21, 18:18
-
core-ci voted on patch set 9 V -1 08/16/21, 19:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15202
-
core-ci voted on patch set 10 V -1 08/16/21, 20:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15206
-
Roman Büchler uploaded patch set 11 08/17/21, 04:35
-
core-ci voted on patch set 11 V -1 08/17/21, 06:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15218
-
Roman Büchler uploaded patch set 12 08/17/21, 08:04
-
core-ci voted on patch set 12 V -1 08/17/21, 08:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15223
-
Roman Büchler uploaded patch set 13 08/17/21, 09:05
-
core-ci voted on patch set 13 V -1 08/17/21, 11:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15226
-
Roman Büchler uploaded patch set 14 08/18/21, 04:51
-
core-ci voted on patch set 14 V -1 08/18/21, 06:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15254
-
Roman Büchler uploaded patch set 15 08/18/21, 07:52
-
core-ci voted on patch set 15 V -1 08/18/21, 09:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15255
-
Roman Büchler uploaded patch set 16 08/18/21, 10:53
-
core-ci voted on patch set 16 V -1 08/18/21, 13:03 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15264
-
Roman Büchler uploaded patch set 17 08/18/21, 17:10
-
core-ci voted on patch set 17 V +1 08/18/21, 17:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15277
-
Jonas Eberle commented on patch set 17 08/18/21, 21:39
Thank you! I have reviewed until typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php - only 100 more to go ;) The ?nullable thing is not strictly necessary at all (will just throw when accessed uninitialised) and could especially be overlooked in test cases where it is initialized in setUp(). Yet still good practice IMHO. It would be great if you could train your phpstan/rector/? AI to respect that. It's great that this revealed some wrong phpdocs types. It feels like archeology :)The used command would be nice to see.RecoveryCodesTest.php:116$codes[0] would be more explicit IMHO.SiteConfigurationTest.php:37?SiteConfigurationSiteConfigurationTest.php:43?string since no default value and not assigned in constructor (according to pinned post in #typo3-core-dev)AbstractConditionMatcherTest.php:54?\ReflectionMethodArgon2iPasswordHashTest.php:28?nullableBcryptPasswordHashTest.php:28?nullableDataHandlerTest.php:326That is because inputValuesRangeDoubleDataProvider() provides string,string|int I suggest the phpdoc here.DataHandlerTest.php:349same hereDataHandlerTest.php:395"string $value" should be possible hereDataHandlerTest.php:724I suggest phpdoc here: bool, int|string|null, int|string|null, string, boolConnectionTest.php:49?nullableMockPlatform.php:147This could also be solved by prophesizing getName() in \TYPO3\CMS\Core\Tests\Unit\Database\Query\Expression\ExpressionBuilderTest::defaultBitwiseAnd": $databasePlatform->getName()->willReturn('someName');BulkInsertTest.php:33?nullableExpressionBuilderTest.php:41?nullableQueryBuilderTest.php:52?nullableDefaultTcaSchemaTest.php:34?nullableTableBuilderTest.php:43?nullableFailsafeContainerTest.php:37?nullableServiceProviderCompilationPassTest.php:39Can't we ": ServiceProviderRegistry" here?EventDispatcherTest.php:39?nullableListenerProviderTest.php:38?nullableAbstractFormProtectionTest.php:28?nullableHtmlParserTest.php:28?nullableMessageTest.php:32?nullable []RequestTest.php:32?nullableResponseTest.php:31?nullableServerRequestTest.php:32?nullableStreamTest.php:32?nullableDimensionTest.php:29?nullableIconFactoryTest.php:204arrayIconFactoryTest.php:244array $sizeBitmapIconProviderTest.php:30?nullableFontawesomeIconProviderTest.php:35?nullableSvgIconProviderTest.php:30?nullableSvgSpriteIconProviderTest.php:30?nullableIconTest.php:38?nullableLinkServiceTest.php:189actually it works 😊LinkServiceTest.php:205actually okPageLinkHandlerTest.php:72should be array, array, stringPageLinkHandlerTest.php:92should be array, array, stringTelephoneLinkHandlerTest.php:83I don't understand this one. The test data is array, array, stringTelephoneLinkHandlerTest.php:99array, array, string -
Roman Büchler commented on patch set 17 08/20/21, 10:27
Thank you for reviewing and the feedback. I reviewed the remaining classes and added the nullable type accordingly.Reply
The changes were manually applied, rector hasn't been used yet...RecoveryCodesTest.php:116ReplyDoneSiteConfigurationTest.php:37ReplyDoneSiteConfigurationTest.php:43ReplyDoneAbstractConditionMatcherTest.php:54ReplyDoneArgon2iPasswordHashTest.php:28ReplyDoneBcryptPasswordHashTest.php:28ReplyDoneDataHandlerTest.php:326ReplyDoneDataHandlerTest.php:349ReplyDoneDataHandlerTest.php:395ReplyDoneDataHandlerTest.php:724ReplyDoneConnectionTest.php:49ReplyDoneMockPlatform.php:147ReplyI am not familiar with prophesizing. Could you give me more information on that?BulkInsertTest.php:33ReplyDoneExpressionBuilderTest.php:41ReplyDoneQueryBuilderTest.php:52ReplyDoneDefaultTcaSchemaTest.php:34ReplyDoneTableBuilderTest.php:43ReplyDoneFailsafeContainerTest.php:37ReplyDoneServiceProviderCompilationPassTest.php:39ReplyDoneEventDispatcherTest.php:39ReplyDoneListenerProviderTest.php:38ReplyDoneAbstractFormProtectionTest.php:28ReplyDoneHtmlParserTest.php:28ReplyDoneMessageTest.php:32ReplyDoneRequestTest.php:32ReplyDoneResponseTest.php:31ReplyDoneServerRequestTest.php:32ReplyDoneStreamTest.php:32ReplyDoneDimensionTest.php:29ReplyDoneIconFactoryTest.php:204ReplyAn error occures when array is declared as return typeIconFactoryTest.php:244ReplyDoneBitmapIconProviderTest.php:30ReplyDoneFontawesomeIconProviderTest.php:35ReplyDoneSvgIconProviderTest.php:30ReplyDoneSvgSpriteIconProviderTest.php:30ReplyDoneIconTest.php:38ReplyDoneLinkServiceTest.php:189ReplyDoneLinkServiceTest.php:205ReplyDonePageLinkHandlerTest.php:72ReplyDonePageLinkHandlerTest.php:92ReplyDoneTelephoneLinkHandlerTest.php:83ReplyDoneTelephoneLinkHandlerTest.php:99ReplyDone -
Roman Büchler uploaded patch set 18 08/20/21, 10:28
-
core-ci voted on patch set 18 V +1 08/20/21, 10:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15324
-
Jonas Eberle commented on patch set 18 08/20/21, 10:57
Reply
DoneYay!MockPlatform.php:147ReplyAll I know is that any dummy object method will return null (https://github.com/phpspec/prophecy#dummies) unless it has a method stub. Looking at the other tests around TYPO3\CMS\Core\Tests\Unit\Database\Query\Expression\ExpressionBuilderTest::defaultBitwiseAnd it looks like it was just forgotten there.IconFactoryTest.php:204ReplyI meant `array $size` (the function is called once for every entry from differentSizesDataProvider()) - actually that data provider looks invalid, but at least it returns an array of arrays (https://phpunit.readthedocs.io/en/9.5/writing-tests-for-phpunit.html?highlight=dataprovider#data-providers) -
Roman Büchler commented on patch set 18 08/20/21, 12:47
MockPlatform.php:147ReplyDoneIconFactoryTest.php:204ReplyDone -
Roman Büchler uploaded patch set 19 08/20/21, 12:48
-
core-ci voted on patch set 19 V +1 08/20/21, 13:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15326
-
Anja Leichsenring voted on patch set 19 V +1 CR +1 08/23/21, 16:56
-
Anja Leichsenring uploaded patch set 20 09/11/21, 09:44
-
core-ci voted on patch set 20 V -1 09/11/21, 09:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16527
-
Anja Leichsenring uploaded patch set 21 09/11/21, 09:55
-
core-ci voted on patch set 21 V -1 09/11/21, 09:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16530
-
Christian Kuhn uploaded patch set 22 09/11/21, 10:06
-
core-ci voted on patch set 22 V -1 09/11/21, 10:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16531
-
Anja Leichsenring uploaded patch set 23 09/11/21, 10:37
-
core-ci voted on patch set 23 V -1 09/11/21, 10:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16532
-
Christian Kuhn uploaded patch set 24 09/11/21, 10:42
-
core-ci voted on patch set 24 V +1 09/11/21, 10:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16533
-
Christian Kuhn voted on patch set 24 V +1 CR +1 09/11/21, 10:56
-
Anja Leichsenring voted on patch set 24 V +2 CR +2 09/11/21, 11:06
-
Anja Leichsenring merged patch set 25 09/11/21, 11:06