70594[BUGFIX] Always remove deletedDropZone in PageTree after dragEnd
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1317
-
Stefan Bürk uploaded patch set 1 08/14/21, 19:51
-
core-ci voted on patch set 1 V +1 08/14/21, 20:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15107
-
Stefan Bürk rebased onto patch set 2 08/19/21, 16:36
-
core-ci voted on patch set 2 V +1 08/19/21, 16:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15309
-
Benni Mack voted on patch set 2 CR +1 08/23/21, 16:28
-
Anja Leichsenring commented on patch set 2 CR -1 08/23/21, 16:52
commit message is confusing. Is the zone now removed when it was shown before, or not? Sorry for nitpicking, this really does not come across. -
Stefan Bürk updated the commit message in patch set 3 08/23/21, 17:02
-
Stefan Bürk commented on patch set 3 08/23/21, 17:03
Reply
Better ? -
Anja Leichsenring updated the commit message in patch set 4 08/23/21, 17:03
-
Anja Leichsenring commented on patch set 4 08/23/21, 17:03
yes, thanks. I removed the duplication, now it works for me. -
core-ci voted on patch set 3 V +1 08/23/21, 17:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15425
-
core-ci voted on patch set 4 V +1 08/23/21, 17:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15426
-
Benni Mack voted on patch set 4 V +1 CR +1 08/23/21, 18:06
-
Wouter Wolters voted on patch set 4 CR +1 08/23/21, 18:07
-
Stefan Bürk voted on patch set 4 V +1 CR +1 08/23/21, 18:27
-
Benni Mack voted on patch set 4 V +2 CR +2 08/23/21, 18:28
-
Benni Mack merged patch set 5 08/23/21, 18:28