Review main Merged

70597[TASK] associate a redirect with the page it was created for

Stefan Busemann CR +2 V +2 Easy +6 −5 updated 08/31/21, 08:25

Commit message

Redirects which are created automatically, should be bound the page, which triggered the redirect, in order to do further future actions (f.e. publish a redirect if in2publish_core is in usage, show redirects for a page to an editor...).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Busemann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jonas Eberle +1
    • Stefan Busemann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Stefan Busemann uploaded patch set 1 08/15/21, 09:16

  2. core-ci voted on patch set 1 V +1 08/15/21, 09:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15114

  3. Stefan Busemann uploaded patch set 2 08/17/21, 06:09

  4. core-ci voted on patch set 2 V +1 08/17/21, 06:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15219

  5. Benni Mack updated the commit message in patch set 3 08/25/21, 15:43

  6. Benni Mack commented on patch set 3 08/25/21, 15:43

    Should we also consider this for existing records? Like an upgrade path?
  7. Benni Mack voted on patch set 3 CR +1 08/25/21, 15:43

  8. core-ci voted on patch set 3 V +1 08/25/21, 16:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15611

  9. Stefan Busemann commented on patch set 3 V +1 CR +1 08/25/21, 18:35

    Reply

    I think that is not necessary, as redirects will get updated / outdated by time. Further it is not easy (or even possible) to identify the affected pids
  10. Jonas Eberle commented on patch set 3 V +1 08/31/21, 07:40

    I understand the usefulness but am a bit wary about the data. If a redirect target gets changed later, this should be reset to 0 IMHO. Are there follow-up patches planned for this feature?
  11. Benni Mack voted on patch set 3 V +2 CR +2 08/31/21, 08:24

  12. Benni Mack merged patch set 4 08/31/21, 08:25