Review main Abandoned

70598[FEATURE] Added the ability to upload folder

Prakash A Bhat CR 0 V 0 Hard +281 −2 updated 11/09/21, 21:11

Commit message

This change now allows one to upload a folder directly into TYPO3 FAL
This now adds some of the Feature as requested in #20558.
This uses the WEBKITDIRECTORY and has some of the following limitations:
a. Sub Directories are not yet
created, this is due a limitaiton of HTTP Input type
b. All files in sub-directories are copied to same main directory - related to the input type again
c. Does not yet have the AJAX uploader support, this feature will soon be added

NOTE to REVIEWERS:
Added the missing Controller

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 7

Review log 1722

  1. Prakash A Bhat uploaded patch set 1 08/15/21, 12:41

  2. Prakash A Bhat uploaded patch set 2 08/15/21, 12:58

  3. core-ci voted on patch set 1 V +1 08/15/21, 13:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15115

  4. core-ci voted on patch set 2 V +1 08/15/21, 13:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15116

  5. Simon Gilli commented on patch set 2 CR -1 08/17/21, 07:33

    Thanks for your patch. Can you please add regression tests.

    Unresolved

    Please remove the WIP tag when your patch is ready to review.

    Unresolved

    As far as I understood you handle the complete issue, if not you should create a new one and add a relation to 20558.

    Unresolved

    11.4 is not needed, please remove it.
  6. Guido Schmechel commented on patch set 2 08/17/21, 07:46

    And another hint: A feature needs an RST file. Help tool for this: https://forger.typo3.com/utilities/rst
  7. Prakash A Bhat marked it work in progress 08/17/21, 08:35

  8. Prakash A Bhat updated the commit message in patch set 3 08/17/21, 08:37

  9. Prakash A Bhat updated the commit message in patch set 4 08/17/21, 08:38

  10. Prakash A Bhat marked it ready for review 08/17/21, 08:40

  11. Prakash A Bhat commented on patch set 4 08/17/21, 08:41

    I have removed the tag WIP, as well as 11.4 tags I also added some notes to reviewers
  12. core-ci voted on patch set 3 V +1 08/17/21, 08:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15224

  13. core-ci voted on patch set 4 V +1 08/17/21, 08:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15225

  14. Oli Bartsch commented on patch set 4 V -1 08/17/21, 11:22

    Hi, thanks for working on this. I'm not sure if you just forgot to push, but the current state is missing the FolderUploadController. This directly leads to an exception when using the "Upload Folder" button in the filelist.
  15. Simon Gilli commented on patch set 4 CR -1 08/18/21, 14:58

    As already mentioned at Slack using Java is a no go for the core, so you have to find another way with JavaScript.
  16. Prakash A Bhat uploaded patch set 5 09/06/21, 07:38

  17. core-ci voted on patch set 5 V -1 09/06/21, 07:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16306

  18. Benni Mack commented on patch set 5 09/07/21, 18:49

    Hey, can you also add your JavaScript code?
  19. Simon Gilli commented on patch set 5 09/22/21, 20:30

    Reply

    It's currently not possible to solve this by JavaScript but the author wants to use client side Java.
  20. Benni Mack commented on patch set 5 09/23/21, 07:34

    Reply Unresolved

    client-side Java? I do think this is possible with JavaScript, I do have a PoC around in my stash, in case we cannot progress here.
  21. Christian Kuhn commented on patch set 5 11/09/21, 21:11

    Hey. This is a pity, but I'll abandon the change for now: Relying on client side java is no solution, if we want to tackle this issue, it has to rely on casual browser functionality. Benni said he stashed something, this issue might be handled with a new patch. Also, all of this handling looks as if it could be done with an extension, too. Maybe this is the right solution to go with this to see if it's stable for everyone and only later introduce it to core? For now, I'll reset the issue to new. And yes, it would be great if folders could be drag&drop uploaded to a fal storage. So please continue here and maybe resurrect the change if feasible.
  22. Christian Kuhn abandoned the change 11/09/21, 21:11