Review main Merged

70601[TASK] Use $this for expectException* methods of PHPunit

Wouter Wolters CR +2 V +2 Normal +117 −117 updated 08/23/21, 17:08

Commit message

The methods are now called statically but are not statically defined.
Use $this instead.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 56

  1. Wouter Wolters uploaded patch set 1 08/15/21, 17:25

  2. core-ci voted on patch set 1 V +1 08/15/21, 17:42 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15124

  3. Oliver Klee voted on patch set 1 CR +1 08/15/21, 19:28

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 08/17/21, 11:47

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 08/23/21, 17:08

  6. Anja Leichsenring merged patch set 2 08/23/21, 17:08