70602[TASK] Strictify UnitTests part 7
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- core-ci +1 CI
Issues 1
Files 9
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentWithRelationsAndSoftrefsTest.php+0 −7
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInEmptyDatabaseTest.php+0 −7
- typo3/sysext/impexp/Tests/Functional/AbstractImportExportTestCase.php+1 −1
- typo3/sysext/impexp/Tests/Functional/ExportTest.php+5 −5
- typo3/sysext/impexp/Tests/Functional/ImportExportTest.php+2 −0
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+2 −0
- typo3/sysext/impexp/Tests/Unit/ExportTest.php+6 −4
- typo3/sysext/indexed_search/Tests/Functional/Utility/LikeWildcardTest.php+2 −2
- typo3/sysext/indexed_search/Tests/Unit/IndexerTest.php+8 −8
Review log 911
-
Wouter Wolters uploaded patch set 1 08/15/21, 17:25
-
Wouter Wolters wrote 08/15/21, 17:43
Topic set to unit-strict -
core-ci voted on patch set 1 V +1 08/15/21, 17:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15125
-
Oliver Klee voted on patch set 1 CR +1 08/15/21, 19:29
-
Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 08/29/21, 19:35
-
Oliver Klee voted on patch set 1 V +1 09/01/21, 15:19
-
Tymoteusz Motylewski rebased onto patch set 2 09/01/21, 15:22
-
Tymoteusz Motylewski commented on patch set 2 09/01/21, 15:23
rebased to see if its still green, if yes, I will merge it as it had enough votes. -
core-ci voted on patch set 2 V +1 09/01/21, 15:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16015
-
Tymoteusz Motylewski commented on patch set 2 V +2 CR +2 09/02/21, 08:50
merging taking into account votes before rebase -
Tymoteusz Motylewski merged patch set 3 09/02/21, 08:50