Review main Merged

70602[TASK] Strictify UnitTests part 7

Wouter Wolters CR +2 V +2 Normal +26 −34 updated 09/02/21, 08:50

Commit message

The following core extensions are handled:

* EXT:impexp
* EXT:indexed_search

Review

  • Code review CR +2 Done
    • Tymoteusz Motylewski +2
  • Verified V +2 Done
    • Tymoteusz Motylewski +2
    • core-ci +1 CI

Issues 1

Files 9

Review log 911

  1. Wouter Wolters uploaded patch set 1 08/15/21, 17:25

  2. Wouter Wolters wrote 08/15/21, 17:43

    Topic set to unit-strict
  3. core-ci voted on patch set 1 V +1 08/15/21, 17:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15125

  4. Oliver Klee voted on patch set 1 CR +1 08/15/21, 19:29

  5. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 08/29/21, 19:35

  6. Oliver Klee voted on patch set 1 V +1 09/01/21, 15:19

  7. Tymoteusz Motylewski rebased onto patch set 2 09/01/21, 15:22

  8. Tymoteusz Motylewski commented on patch set 2 09/01/21, 15:23

    rebased to see if its still green, if yes, I will merge it as it had enough votes.
  9. core-ci voted on patch set 2 V +1 09/01/21, 15:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16015

  10. Tymoteusz Motylewski commented on patch set 2 V +2 CR +2 09/02/21, 08:50

    merging taking into account votes before rebase
  11. Tymoteusz Motylewski merged patch set 3 09/02/21, 08:50