Review main Merged

70618[BUGFIX] Do not show language switch in edit multiple

Oli Bartsch CR +2 V +2 Easy +16 −5 updated 08/23/21, 12:00

Commit message

FormEngine allows to edit multiple records at once.
This view can e.g. be accessed using the recordlists'
"Edit marked" button.

Since the "language switcher" only affects the first
displayed record, it is now not longer rendered, when
in "edit multiple" view.

To improve readability of the code, all those places
now use the same "speaking" method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 811

  1. Oli Bartsch uploaded patch set 1 08/16/21, 11:37

  2. core-ci voted on patch set 1 V +1 08/16/21, 12:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15169

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/16/21, 12:07

  4. Jochen Roth commented on patch set 1 08/16/21, 15:17

    EditDocumentController.php:2582

    `... only only element exists in $elementsData.` Did you mean "only one element"?
  5. Oli Bartsch commented on patch set 2 08/16/21, 15:19

    Published edit on patch set 1.
  6. Oli Bartsch commented on patch set 2 08/16/21, 15:19

    EditDocumentController.php:2582 Reply

    Done
  7. core-ci voted on patch set 2 V -1 08/16/21, 15:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15194

  8. core-ci voted on patch set 2 V +1 08/17/21, 09:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15194

  9. Jochen Roth voted on patch set 2 V +1 CR +1 08/17/21, 09:30

  10. Benni Mack voted on patch set 2 V +2 CR +2 08/23/21, 12:00

  11. Benni Mack merged patch set 3 08/23/21, 12:00