Review TYPO3_4-5 Merged

7063[BUGFIX] Remove hardcoded limits in T3D export

Markus Klein CR +2 V +2 Easy +0 −8 updated 06/03/13, 20:49

Commit message

The memory_limit is hardcoded to 256m and
max_execution_time to 600.

There is no reason to hardcode those settings,
sometimes a bit more of both is needed.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Stefan Neufeind +1
    • Oliver Klee +1
    • Sebastian Fischer +1
  • Verified V +2
    • Georg Ringer +2

Issues 4

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 12/05/11, 12:10

    Looks good to me, but someone else must approve Trivial change. Hmm, how come this backport slipped under our radar until now? Thanks for the backport.
  2. Markus Klein commented on patch set 1 12/05/11, 12:10

  3. Markus Klein commented on patch set 1 12/05/11, 12:10

    @Stefan: Yes, that's probably one of the biggest problems of TYPO3 at the moment. Lacking support for older versions because of forgotten or "stuck" backports. :-( The forgotten ones can luckily be found using Benni's magic script, but the pending ones need more discipline of the devs to consequently vote/submit the backports instead of looking at new bugs.
  4. Oliver Klee commented on patch set 1 12/05/11, 12:10

    Looks good to me, but someone else must approve
  5. Georg Ringer commented on patch set 1 V 0 12/05/11, 12:10

    by team member; Looks good to me, approved
  6. Sebastian Fischer commented on patch set 1 12/05/11, 12:10

    Looks good to me, but someone else must approve
  7. Georg Ringer merged patch set 1 12/05/11, 12:10