70632[TASK] Strictify UnitTests part 8
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 86
- typo3/sysext/dashboard/Tests/Unit/DependencyInjection/DashboardWidgetPassTest.php+4 −5
- typo3/sysext/dashboard/Tests/Unit/WidgetRegistryTest.php+5 −6
- typo3/sysext/extbase/Tests/Fixture/ClassWithGettersAndSetters.php+2 −2
- typo3/sysext/extbase/Tests/Fixture/ClassWithSetters.php+2 −2
- typo3/sysext/extbase/Tests/Fixture/ClassWithSettersAndConstructor.php+1 −1
- typo3/sysext/extbase/Tests/Fixture/DummyClass.php+1 −1
- typo3/sysext/extbase/Tests/Fixture/Entity.php+4 −9
- typo3/sysext/extbase/Tests/Fixture/ValueObject.php+4 −6
- typo3/sysext/extbase/Tests/Unit/Configuration/AbstractConfigurationManagerTest.php+7 −17
- typo3/sysext/extbase/Tests/Unit/Configuration/BackendConfigurationManagerTest.php+14 −12
- typo3/sysext/extbase/Tests/Unit/Configuration/FrontendConfigurationManagerTest.php+9 −8
- typo3/sysext/extbase/Tests/Unit/DomainObject/AbstractEntityTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Error/ErrorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Error/MessageTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Error/ResultTest.php+18 −23
- typo3/sysext/extbase/Tests/Unit/Hook/DataHandler/CheckFlexFormValueTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ActionControllerTest.php+40 −38
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/ArgumentTest.php+3 −10
- typo3/sysext/extbase/Tests/Unit/Mvc/Controller/MvcPropertyMappingConfigurationServiceTest.php+14 −14
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+1 −1
Show 66 more files
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php+60 −57
- typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Object/Container/Fixtures/ContainerConstructorInjectionTestFixtures.php+18 −59
- typo3/sysext/extbase/Tests/Unit/Object/Container/Fixtures/Testclasses.php+41 −118
- typo3/sysext/extbase/Tests/Unit/Object/Container/ContainerTest.php+56 −56
- typo3/sysext/extbase/Tests/Unit/Persistence/Fixture/Model/Entity2.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Fixture/Model/Entity3.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/Fixture/DummyEntity.php+1 −0
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/Fixture/DummyParentEntity.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapFactoryTest.php+25 −25
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Mapper/DataMapperTest.php+20 −18
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+5 −3
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+32 −29
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+6 −4
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/PersistenceManagerTest.php+3 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryFactoryTest.php+6 −11
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryResultTest.php+19 −22
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/QueryTest.php+14 −12
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/SessionTest.php+10 −10
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Typo3QuerySettingsTest.php+3 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/ObjectStorageTest.php+20 −20
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+33 −30
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/Fixtures/DateTimeSubFixture.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/ArrayConverterTest.php+4 −7
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/BooleanConverterTest.php+5 −8
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/DateTimeConverterTest.php+29 −32
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/FloatConverterTest.php+12 −11
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/IntegerConverterTest.php+12 −11
- typo3/sysext/extbase/Tests/Unit/Property/TypeConverter/StringConverterTest.php+6 −5
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationBuilderTest.php+2 −5
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationTest.php+21 −24
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/MethodTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/Validation/Validator/DummyValidator.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/ArrayAccessClass.php+4 −7
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfMethods.php+14 −14
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithGettersAndSetters.php+14 −14
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyControllerWithIgnoreValidationDoctrineAnnotation.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+16 −16
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+41 −44
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+3 −1
- typo3/sysext/extbase/Tests/Unit/Security/Cryptography/HashServiceTest.php+11 −14
- typo3/sysext/extbase/Tests/Unit/Service/CacheServiceTest.php+6 −6
- typo3/sysext/extbase/Tests/Unit/Service/ExtensionServiceTest.php+22 −23
- typo3/sysext/extbase/Tests/Unit/Service/ImageScriptServiceTest.php+1 −4
- typo3/sysext/extbase/Tests/Unit/Utility/DebuggerUtilityTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Utility/ExtensionUtilityTest.php+19 −19
- typo3/sysext/extbase/Tests/Unit/Utility/LocalizationUtilityTest.php+14 −15
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/Fixture/AbstractCompositeValidatorClass.php+4 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/Fixture/AbstractValidatorClass.php+2 −1
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/AlphanumericValidatorTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/BooleanValidatorTest.php+8 −8
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/CollectionValidatorTest.php+7 −10
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/ConjunctionValidatorTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DateTimeValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/DisjunctionValidatorTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/FloatValidatorTest.php+5 −8
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/GenericObjectValidatorTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/IntegerValidatorTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NotEmptyValidatorTest.php+9 −12
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberRangeValidatorTest.php+5 −8
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/NumberValidatorTest.php+5 −7
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/RegularExpressionValidatorTest.php+5 −5
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringLengthValidatorTest.php+17 −17
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/StringValidatorTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/TextValidatorTest.php+6 −9
- typo3/sysext/extbase/Tests/Unit/Validation/Validator/UrlValidatorTest.php+2 −5
Review log 1220
-
Roman Büchler uploaded patch set 1 08/16/21, 12:11
-
Roman Büchler wrote 08/16/21, 12:12
Topic set to unit-strict -
core-ci voted on patch set 1 V -1 08/16/21, 12:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15172
-
Roman Büchler uploaded patch set 2 08/16/21, 12:23
-
core-ci voted on patch set 2 V -1 08/16/21, 12:34 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15181
-
Roman Büchler rebased onto patch set 3 08/16/21, 12:45
-
Roman Büchler uploaded patch set 4 08/16/21, 12:48
-
core-ci voted on patch set 3 V -1 08/16/21, 12:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15184
-
core-ci voted on patch set 4 V -1 08/16/21, 13:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15185
-
Roman Büchler uploaded patch set 5 08/18/21, 17:39
-
core-ci voted on patch set 5 V -1 08/18/21, 17:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15279
-
Roman Büchler uploaded patch set 6 08/18/21, 18:02
-
core-ci voted on patch set 6 V -1 08/18/21, 18:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15280
-
Christian Kuhn rebased onto patch set 7 09/11/21, 11:40
-
core-ci voted on patch set 7 V -1 09/11/21, 12:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16543
-
Christian Kuhn uploaded patch set 8 09/11/21, 12:24
-
core-ci voted on patch set 8 V +1 09/11/21, 12:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16547
-
Christian Kuhn voted on patch set 8 V +1 CR +1 09/11/21, 12:42
-
Anja Leichsenring voted on patch set 8 V +2 CR +2 09/11/21, 12:50
-
Anja Leichsenring merged patch set 9 09/11/21, 12:50