70639[TASK] Add acceptance test for sitemap
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1926
Show 1 earlier messages
-
Jochen Roth uploaded patch set 1 08/16/21, 12:30
-
Jochen Roth commented on patch set 1 08/16/21, 12:31
Depends on https://github.com/TYPO3/styleguide/pull/235 -
core-ci voted on patch set 1 V -1 08/16/21, 12:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15182
-
Guido Schmechel commented on patch set 1 08/16/21, 13:26
Probider vs. Provider :-)SitemapXmlCest.php:81Probider vs. Provider :-) -
Guido Schmechel commented on patch set 1 08/16/21, 13:27
The favicon probably slipped in here by mistake? -
Jochen Roth uploaded patch set 2 08/16/21, 20:10
-
Jochen Roth commented on patch set 2 08/16/21, 20:12
Reply
Done :-)Reply
It's actually needed otherwise codeception is complaining about a 404 error while retrieving the favicon.icoSitemapXmlCest.php:81ReplyDone -
core-ci voted on patch set 2 V -1 08/16/21, 20:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15210
-
Jochen Roth uploaded patch set 3 08/30/21, 14:46
-
Jochen Roth commented on patch set 3 CR -1 08/30/21, 14:48
Still, depends on https://github.com/TYPO3/styleguide/pull/235 being released. Just changed the test location. -
core-ci voted on patch set 3 V -1 08/30/21, 15:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15873
-
Jochen Roth uploaded patch set 4 10/07/21, 21:24
-
core-ci voted on patch set 4 V -1 10/07/21, 21:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17785
-
Benni Mack commented on patch set 4 CR -1 10/14/21, 06:52
we won't add the favicon.ico :) so this needs to be handled in the test -
Jochen Roth uploaded patch set 5 10/14/21, 13:05
-
core-ci voted on patch set 5 V -1 10/14/21, 13:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18102
-
Jochen Roth commented on patch set 5 10/14/21, 13:16
Reply
We have to have that favicon.ico in the doc-root for testing. Therefore the test symlinks a favicon from EXT:backend within the test environment. -
Jochen Roth rebased onto patch set 6 10/18/21, 08:01
-
core-ci voted on patch set 6 V -1 10/18/21, 08:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18277
-
Jochen Roth uploaded patch set 7 10/18/21, 12:38
-
core-ci voted on patch set 7 V +1 10/18/21, 12:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18279
-
Christian Kuhn commented on patch set 7 V +1 CR +1 10/19/21, 13:11
Reply
BE uses ext:backend/resources/public/icons/favicon.ico. i suggest to configure our test frontend to use the same. -
Stefan Bürk voted on patch set 7 CR +1 10/19/21, 13:20
-
Stefan Bürk voted on patch set 7 V +1 10/19/21, 13:21
-
Christian Kuhn voted on patch set 7 V +2 CR +2 10/19/21, 13:21
-
Christian Kuhn merged patch set 8 10/19/21, 13:21