Review main Merged

70640[BUGFIX] Resolving page slug ending with index and type suffix '.php'

Stefan Bürk CR +2 V +2 Hard +226 −38 updated 01/05/22, 11:42

Commit message

If a page slug ends with 'index' and site has a routing
configuration with a PageTypeSuffix with index and suffix
'.php' as default suffix, route resolving cuts 'index.php'
from the uri, ending with a slug without index in it and
thus not resolving the page and displaying 404 page.

The reason for this is the code fragment which strips the
document root from the uri as a cleanup for some systems,
and fixes an issue for calling id/type parameters with
index.php (main entry point), which has been added as a
bugfix in v9 with #88028.

There was a first attempt to fix this page resolving issue
with #94537, which has been a regression and reverted with
issue #94968.

To ensure everything works and regression is covered before
a new patch, there has been two patches with #95096 and #95362.

After the regression there has been a really deep analysis,
to get all puzzle pieces together over the time, which ended
in the pre-patches and finally in this patch.

The stripping of the document root has been implemented to
late in the resolving chain to solve #88028, thus the followup
fixes interferred with the resolving concept. This patch moves
this stripping from the page-resolving point some steps early
to the site-resolving step, and doing the stripping only on
the left site of the uri and avoiding a generall str_replace(),
thus fixing past issues and the current issue in the correct
place.

Furthermore tests for this issue are (re)added with this patch,
as they were removed with the revert.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 6

Files 5

Review log 3151

Show 1426 earlier messages
  1. Stefan Bürk uploaded patch set 1 08/16/21, 16:52

  2. core-ci voted on patch set 1 V +1 08/16/21, 17:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15199

  3. Stephan Großberndt voted on patch set 1 V +1 08/16/21, 17:27

  4. Stefan Bürk marked it work in progress 08/17/21, 10:11

  5. Stefan Bürk updated the commit message in patch set 2 08/17/21, 10:23

  6. core-ci voted on patch set 2 V +1 08/17/21, 10:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15228

  7. Stefan Bürk uploaded patch set 3 08/18/21, 19:59

  8. core-ci voted on patch set 3 V -1 08/18/21, 20:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15287

  9. Stefan Bürk uploaded patch set 4 08/18/21, 20:28

  10. Stefan Bürk uploaded patch set 5 08/18/21, 20:45

  11. core-ci voted on patch set 4 V +1 08/18/21, 20:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15288

  12. core-ci voted on patch set 5 V +1 08/18/21, 21:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15289

  13. Stefan Bürk uploaded patch set 6 08/20/21, 13:19

  14. core-ci voted on patch set 6 V -1 08/20/21, 13:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15327

  15. Stefan Bürk uploaded patch set 7 08/21/21, 20:02

  16. core-ci voted on patch set 7 V -1 08/21/21, 20:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15369

  17. Stefan Bürk uploaded patch set 8 08/22/21, 11:33

  18. core-ci voted on patch set 8 V -1 08/22/21, 11:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15382

  19. Stefan Bürk uploaded patch set 9 08/22/21, 12:26

  20. core-ci voted on patch set 9 V -1 08/22/21, 12:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15384

  21. Stefan Bürk uploaded patch set 10 08/23/21, 19:14

  22. core-ci voted on patch set 10 V -1 08/23/21, 19:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15456

  23. Stefan Bürk uploaded patch set 11 08/31/21, 17:39

  24. core-ci voted on patch set 11 V -1 08/31/21, 17:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15960

  25. Stefan Bürk uploaded patch set 12 09/30/21, 14:54

  26. core-ci voted on patch set 12 V -1 09/30/21, 15:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17353

  1. Stephan Großberndt wrote 09/30/21, 16:07

    Change message removed by: Stephan Großberndt

    SiteRequestSubInstanceTest.php:104

    getInstancePathPrefix() does not exist
  2. Stephan Großberndt marked it work in progress 09/30/21, 16:07

  3. Stefan Bürk commented on patch set 12 09/30/21, 16:12

    SiteRequestSubInstanceTest.php:104 Reply

    See commit message: ``` Testingframework subinstance tests are not avaialbe yet, but it is in work. This patch includes first subinstance test which are not runnable yet. ``` Not missing if testing-framework fork would have been checked out as described in commit message. Needs a PR merged in TF first and released.
  4. Stefan Bürk uploaded patch set 13 10/21/21, 17:22

  5. core-ci voted on patch set 13 V +1 10/21/21, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18410

  6. Stefan Bürk uploaded patch set 14 11/27/21, 19:37

  7. core-ci voted on patch set 14 V +1 11/27/21, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19892

  8. Stefan Bürk rebased onto patch set 15 11/29/21, 00:29

  9. core-ci voted on patch set 15 V +1 11/29/21, 00:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19957

  10. Benni Mack wrote 11/29/21, 10:22

    Change destination moved from master to main
  11. Benni Mack updated the commit message in patch set 16 11/29/21, 14:12

  12. core-ci voted on patch set 16 V +1 11/29/21, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20128

  13. Stefan Bürk rebased onto patch set 17 12/05/21, 01:21

  14. core-ci voted on patch set 17 V +1 12/05/21, 01:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20591

  15. Stefan Bürk uploaded patch set 18 12/14/21, 03:38

  16. core-ci voted on patch set 18 V -1 12/14/21, 03:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21056

  17. Stefan Bürk uploaded patch set 19 12/14/21, 04:14

  18. Stefan Bürk marked it ready for review 12/14/21, 04:24

  19. core-ci voted on patch set 19 V +1 12/14/21, 04:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21057

  20. Stefan Bürk rebased onto patch set 20 12/23/21, 15:37

  21. core-ci voted on patch set 20 V +1 12/23/21, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21435

  22. Benni Mack voted on patch set 20 V +1 CR +1 12/23/21, 16:30

  23. Oli Bartsch voted on patch set 20 V +1 CR +1 01/05/22, 10:21

  24. Benni Mack voted on patch set 20 V +2 CR +2 01/05/22, 11:42

  25. Benni Mack merged patch set 21 01/05/22, 11:42