70640[BUGFIX] Resolving page slug ending with index and type suffix '.php'
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 6
- Bug #94905FE requests to /index.php are broken without providing id get parameter, if no pageTypeSuffix routeEnhancer is configured
- Task #95096Cover FE index.php id/type parameter
- Task #95362Add eID controller request processing test
- Bug #94537Page could not be resolved if page slug ending in index and using PageSuffix RouteEnhancer to add .php suffix to all pages of a site.
- Task #94968Revert #94537 due to incompatibilities with certain server setups
- Bug #88028index.php results in 404
Files 5
- typo3/sysext/core/Classes/Routing/PageRouter.php+0 −12
- typo3/sysext/core/Classes/Routing/SiteMatcher.php+21 −6
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Builder.php+19 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EidRequestTest.php+169 −20
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+17 −0
Review log 3151
Show 1426 earlier messages
-
Stefan Bürk uploaded patch set 1 08/16/21, 16:52
-
core-ci voted on patch set 1 V +1 08/16/21, 17:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15199
-
Stephan Großberndt voted on patch set 1 V +1 08/16/21, 17:27
-
Stefan Bürk marked it work in progress 08/17/21, 10:11
-
Stefan Bürk updated the commit message in patch set 2 08/17/21, 10:23
-
core-ci voted on patch set 2 V +1 08/17/21, 10:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15228
-
Stefan Bürk uploaded patch set 3 08/18/21, 19:59
-
core-ci voted on patch set 3 V -1 08/18/21, 20:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15287
-
Stefan Bürk uploaded patch set 4 08/18/21, 20:28
-
Stefan Bürk uploaded patch set 5 08/18/21, 20:45
-
core-ci voted on patch set 4 V +1 08/18/21, 20:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15288
-
core-ci voted on patch set 5 V +1 08/18/21, 21:03 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15289
-
Stefan Bürk uploaded patch set 6 08/20/21, 13:19
-
core-ci voted on patch set 6 V -1 08/20/21, 13:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15327
-
Stefan Bürk uploaded patch set 7 08/21/21, 20:02
-
core-ci voted on patch set 7 V -1 08/21/21, 20:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15369
-
Stefan Bürk uploaded patch set 8 08/22/21, 11:33
-
core-ci voted on patch set 8 V -1 08/22/21, 11:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15382
-
Stefan Bürk uploaded patch set 9 08/22/21, 12:26
-
core-ci voted on patch set 9 V -1 08/22/21, 12:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15384
-
Stefan Bürk uploaded patch set 10 08/23/21, 19:14
-
core-ci voted on patch set 10 V -1 08/23/21, 19:33 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15456
-
Stefan Bürk uploaded patch set 11 08/31/21, 17:39
-
core-ci voted on patch set 11 V -1 08/31/21, 17:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15960
-
Stefan Bürk uploaded patch set 12 09/30/21, 14:54
-
core-ci voted on patch set 12 V -1 09/30/21, 15:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17353
-
Stephan Großberndt wrote 09/30/21, 16:07
Change message removed by: Stephan GroßberndtSiteRequestSubInstanceTest.php:104getInstancePathPrefix() does not exist -
Stephan Großberndt marked it work in progress 09/30/21, 16:07
-
Stefan Bürk commented on patch set 12 09/30/21, 16:12
SiteRequestSubInstanceTest.php:104ReplySee commit message: ``` Testingframework subinstance tests are not avaialbe yet, but it is in work. This patch includes first subinstance test which are not runnable yet. ``` Not missing if testing-framework fork would have been checked out as described in commit message. Needs a PR merged in TF first and released. -
Stefan Bürk uploaded patch set 13 10/21/21, 17:22
-
core-ci voted on patch set 13 V +1 10/21/21, 17:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18410
-
Stefan Bürk uploaded patch set 14 11/27/21, 19:37
-
core-ci voted on patch set 14 V +1 11/27/21, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19892
-
Stefan Bürk rebased onto patch set 15 11/29/21, 00:29
-
core-ci voted on patch set 15 V +1 11/29/21, 00:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19957
-
Benni Mack wrote 11/29/21, 10:22
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 16 11/29/21, 14:12
-
core-ci voted on patch set 16 V +1 11/29/21, 18:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20128
-
Stefan Bürk rebased onto patch set 17 12/05/21, 01:21
-
core-ci voted on patch set 17 V +1 12/05/21, 01:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20591
-
Stefan Bürk uploaded patch set 18 12/14/21, 03:38
-
core-ci voted on patch set 18 V -1 12/14/21, 03:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21056
-
Stefan Bürk uploaded patch set 19 12/14/21, 04:14
-
Stefan Bürk marked it ready for review 12/14/21, 04:24
-
core-ci voted on patch set 19 V +1 12/14/21, 04:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21057
-
Stefan Bürk rebased onto patch set 20 12/23/21, 15:37
-
core-ci voted on patch set 20 V +1 12/23/21, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/21435
-
Benni Mack voted on patch set 20 V +1 CR +1 12/23/21, 16:30
-
Oli Bartsch voted on patch set 20 V +1 CR +1 01/05/22, 10:21
-
Benni Mack voted on patch set 20 V +2 CR +2 01/05/22, 11:42
-
Benni Mack merged patch set 21 01/05/22, 11:42