70642[TASK] Strictify UnitTests part 9
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 74
- typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+3 −1
- typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php+21 −24
- typo3/sysext/frontend/Tests/Functional/ContentObject/FluidTemplateContentObjectTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Controller/TypoScriptFrontendControllerTest.php+5 −4
- typo3/sysext/frontend/Tests/Functional/Imaging/GifBuilderTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/LocalizedSiteContentRenderingTest.php+4 −4
- typo3/sysext/frontend/Tests/Functional/Rendering/TitleTagRenderingTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/Rendering/UriPrefixRenderingTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/AbstractEnhancerLinkGeneratorTestCase.php+2 −5
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGenerator/DefaultExtbaseControllerTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/AbstractEnhancerSiteRequestTest.php+3 −6
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/RouteTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/ApplicableConjunction.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/AspectDeclaration.php+2 −12
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/EnhancerDeclaration.php+4 −19
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/ExceptionExpectation.php+4 −19
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/LanguageContext.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/PageTypeDeclaration.php+6 −25
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Permutation.php+4 −4
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/TestSet.php+5 −5
Show 54 more files
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Variable.php+2 −9
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariableCompiler.php+4 −19
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariableItem.php+3 −10
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariablesContext.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariableValue.php+5 −5
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/AbstractLocalizedPagesTestCase.php+2 −6
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioBTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioCTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioDTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioETest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/LocalizedPageRendering/ScenarioFTest.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/AbstractTestCase.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php+7 −10
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+17 −22
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+12 −15
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugSiteRequestTest.php+23 −26
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php+7 −10
- typo3/sysext/frontend/Tests/Functional/Tca/BackendLayoutVisibleFieldsTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Tca/ContentVisibleFieldsTest.php+5 −5
- typo3/sysext/frontend/Tests/Functional/Tca/FrontendGroupsVisibleFieldsTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Tca/FrontendUsersVisibleFieldsTest.php+2 −2
- typo3/sysext/frontend/Tests/Functional/Tca/PagesLanguageOverlayVisibleFieldsTest.php+3 −3
- typo3/sysext/frontend/Tests/Functional/Tca/TemplateVisibleFieldsTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php+13 −11
- typo3/sysext/frontend/Tests/Unit/ContentObject/Exception/ProductionExceptionHandlerTest.php+3 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/Fixtures/DataProcessorFixture.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Fixtures/TestSanitizerBuilder.php+1 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+22 −20
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/MenuContentObjectFactoryTest.php+7 −7
- typo3/sysext/frontend/Tests/Unit/ContentObject/CaseContentObjectTest.php+5 −3
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentDataProcessorTest.php+1 −4
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+46 −45
- typo3/sysext/frontend/Tests/Unit/ContentObject/FilesContentObjectTest.php+33 −31
- typo3/sysext/frontend/Tests/Unit/ContentObject/FluidTemplateContentObjectTest.php+16 −14
- typo3/sysext/frontend/Tests/Unit/ContentObject/ImageContentObjectTest.php+25 −29
- typo3/sysext/frontend/Tests/Unit/Controller/ErrorControllerTest.php+15 −14
- typo3/sysext/frontend/Tests/Unit/Controller/TypoScriptFrontendControllerTest.php+27 −23
- typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php+6 −3
- typo3/sysext/frontend/Tests/Unit/DataProcessing/SiteProcessorTest.php+5 −3
- typo3/sysext/frontend/Tests/Unit/Fixtures/AdminPanelHookWithoutInterfaceFixture.phpdeleted+0 −25
- typo3/sysext/frontend/Tests/Unit/Fixtures/ResultBrowserPluginHook.php+1 −1
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+20 −18
- typo3/sysext/frontend/Tests/Unit/Middleware/PageArgumentValidatorTest.php+10 −19
- typo3/sysext/frontend/Tests/Unit/Middleware/PageResolverTest.php+9 −9
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteBaseRedirectResolverTest.php+3 −6
- typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest.php+12 −17
- typo3/sysext/frontend/Tests/Unit/Middleware/StaticRouteResolverTest.php+5 −3
- typo3/sysext/frontend/Tests/Unit/Page/CacheHashCalculatorTest.php+15 −15
- typo3/sysext/frontend/Tests/Unit/Page/PageAccessFailureReasonsTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/Plugin/AbstractPluginTest.php+8 −9
- typo3/sysext/frontend/Tests/Unit/Processor/GalleryProcessorTest.php+13 −12
- typo3/sysext/frontend/Tests/Unit/Service/TypoLinkCodecServiceTest.php+5 −8
- typo3/sysext/frontend/Tests/Unit/Typolink/AbstractTypolinkBuilderTest.php+13 −10
- typo3/sysext/frontend/Tests/Unit/Typolink/DatabaseRecordLinkBuilderTest.php+3 −1
Review log 1016
-
Wouter Wolters uploaded patch set 1 08/16/21, 18:54
-
Wouter Wolters wrote 08/16/21, 18:55
Topic set to unit-strict -
core-ci voted on patch set 1 V -1 08/16/21, 19:10 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15207
-
Wouter Wolters uploaded patch set 2 08/17/21, 17:26
-
core-ci voted on patch set 2 V -1 08/17/21, 17:54 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15240
-
Anja Leichsenring uploaded patch set 3 09/11/21, 10:48
-
Anja Leichsenring uploaded patch set 4 09/11/21, 10:52
-
core-ci voted on patch set 3 V -1 09/11/21, 11:04 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16535
-
core-ci voted on patch set 4 V -1 09/11/21, 11:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16536
-
Anja Leichsenring uploaded patch set 5 09/11/21, 11:17
-
Anja Leichsenring uploaded patch set 6 09/11/21, 11:33
-
core-ci voted on patch set 5 V -1 09/11/21, 11:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16540
-
core-ci voted on patch set 6 V +1 09/11/21, 11:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16541
-
Christian Kuhn voted on patch set 6 V +1 CR +1 09/11/21, 12:18
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 09/11/21, 12:18
-
Anja Leichsenring merged patch set 7 09/11/21, 12:18