70652[TASK] Add missing breaking rst for form setup mixins removal
Commit message
Review
-
Code review CR +2 Done
- waldhacker +2
- Mathias Brodala +1
-
Verified V +2 Done
- waldhacker +2
- Mathias Brodala +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
waldhacker uploaded patch set 1 08/17/21, 06:58
-
waldhacker updated the commit message in patch set 2 08/17/21, 06:59
-
Mathias Brodala commented on patch set 2 CR -1 08/17/21, 07:03
I'm a bit confused. The RST talks aboutBreaking-70528-DeprecatedFormSetupRemoved.rst:4... mixins ... is missing here.Breaking-70528-DeprecatedFormSetupRemoved.rst:17not work properly anymoreBreaking-70528-DeprecatedFormSetupRemoved.rst:22the -
Mathias Brodala commented on patch set 2 08/17/21, 07:03
Reply
Forget about this comment. ;-) -
waldhacker uploaded patch set 3 08/17/21, 07:07
-
waldhacker commented on patch set 3 08/17/21, 07:07
Breaking-70528-DeprecatedFormSetupRemoved.rst:4ReplyDoneBreaking-70528-DeprecatedFormSetupRemoved.rst:17ReplyDoneBreaking-70528-DeprecatedFormSetupRemoved.rst:22ReplyDone -
Mathias Brodala voted on patch set 3 V +1 CR +1 08/17/21, 07:15
-
core-ci voted on patch set 1 V +1 08/17/21, 07:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15220
-
core-ci voted on patch set 3 V +1 08/17/21, 07:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15222
-
core-ci voted on patch set 2 V +1 08/17/21, 07:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15221
-
waldhacker voted on patch set 3 V +2 CR +2 08/18/21, 18:16
-
waldhacker merged patch set 4 08/18/21, 18:16
-
Oliver Hader commented on patch set 4 09/06/21, 09:32
Filename should have contained #94911 (issue number), not Gerrit review... -
waldhacker commented on patch set 4 09/06/21, 09:34
Reply
shame on me, sorry for that :/ Should I push a correction in a new patchset? -
Oliver Hader commented on patch set 4 09/06/21, 17:37
Reply
> Should I push a correction in a new patchset? I guess you know the answer... ;-) Anyway, did it: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70920