Review main Merged

70652[TASK] Add missing breaking rst for form setup mixins removal

waldhacker CR +2 V +2 Easy +29 −0 updated 09/06/21, 17:37

Commit message

Adds the forgotten breaking rst for the ticket
https://review.typo3.org/c/Packages/TYPO3.CMS/+/70528/

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • waldhacker +2
    • Mathias Brodala +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1215

  1. waldhacker uploaded patch set 1 08/17/21, 06:58

  2. waldhacker updated the commit message in patch set 2 08/17/21, 06:59

  3. Mathias Brodala commented on patch set 2 CR -1 08/17/21, 07:03

    I'm a bit confused. The RST talks about

    Breaking-70528-DeprecatedFormSetupRemoved.rst:4

    ... mixins ... is missing here.

    Breaking-70528-DeprecatedFormSetupRemoved.rst:17

    not work properly anymore

    Breaking-70528-DeprecatedFormSetupRemoved.rst:22

    the
  4. Mathias Brodala commented on patch set 2 08/17/21, 07:03

    Reply

    Forget about this comment. ;-)
  5. waldhacker uploaded patch set 3 08/17/21, 07:07

  6. waldhacker commented on patch set 3 08/17/21, 07:07

    Breaking-70528-DeprecatedFormSetupRemoved.rst:4 Reply

    Done

    Breaking-70528-DeprecatedFormSetupRemoved.rst:17 Reply

    Done

    Breaking-70528-DeprecatedFormSetupRemoved.rst:22 Reply

    Done
  7. Mathias Brodala voted on patch set 3 V +1 CR +1 08/17/21, 07:15

  8. core-ci voted on patch set 1 V +1 08/17/21, 07:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15220

  9. core-ci voted on patch set 3 V +1 08/17/21, 07:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15222

  10. core-ci voted on patch set 2 V +1 08/17/21, 07:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15221

  11. waldhacker voted on patch set 3 V +2 CR +2 08/18/21, 18:16

  12. waldhacker merged patch set 4 08/18/21, 18:16

  13. Oliver Hader commented on patch set 4 09/06/21, 09:32

    Filename should have contained #94911 (issue number), not Gerrit review...
  14. waldhacker commented on patch set 4 09/06/21, 09:34

    Reply

    shame on me, sorry for that :/ Should I push a correction in a new patchset?
  15. Oliver Hader commented on patch set 4 09/06/21, 17:37

    Reply

    > Should I push a correction in a new patchset? I guess you know the answer... ;-) Anyway, did it: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70920