7067[BUGFIX] Misinterpretaion of memory_limit setting in install tool
Commit message
Review
-
Code review CR +2
- Ernesto Baschny +2
- Wouter Wolters +1
- Philipp Gampe +1
-
Verified V +2
- Ernesto Baschny +2
- Philipp Gampe +1
Files 2
Review log 14
-
Markus Klein commented on patch set 1 01/26/12, 15:16
Looks good to me, but someone else must approveclass.tx_install.php:2271$memory_limit_value is an integer. Compare with === -1 please.class.tx_install.php:2296Isn't this case very similar to the -1 case? -
Markus Klein commented on patch set 1 1 comment 01/26/12, 15:16
No score -
Stefan Neufeind commented on patch set 2 01/26/12, 15:16
Looks good to me, but someone else must approve And you might also want to review: http://review.typo3.org/7040 -
Markus Klein uploaded patch set 2 01/26/12, 15:16
-
Ernesto Baschny commented on patch set 3 V 0 01/26/12, 15:16
by team member; Looks good to me, approved -
Markus Klein uploaded patch set 3 01/26/12, 15:16
-
Markus Klein commented on patch set 3 01/26/12, 15:16
Rebase and Commit message fix. -
Sebastian Fischer commented on patch set 2 01/26/12, 15:16
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 3 01/26/12, 15:16
Verified; Looks good to me, but someone else must approve Works for me :) -
Mr. Jenkins commented on patch set 1 01/26/12, 15:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2590/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/26/12, 15:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2594/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/26/12, 15:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3019/ : SUCCESS -
Wouter Wolters commented on patch set 3 01/26/12, 15:16
Looks good to me, but someone else must approve -
Ernesto Baschny merged patch set 3 01/26/12, 15:16