Review main Merged

7067[BUGFIX] Misinterpretaion of memory_limit setting in install tool

Mario Rimann CR +2 V +2 Easy +19 −18 updated 06/03/13, 20:49

Commit message

Adds a different warning into the system checks of the basic
configuration section of the install tool in case the memory_limit
is set to "-1" which means unlimited according to the PHP docs.

Review

  • Code review CR +2
    • Ernesto Baschny +2
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Ernesto Baschny +2
    • Philipp Gampe +1

Files 2

Review log 14

  1. Markus Klein commented on patch set 1 01/26/12, 15:16

    Looks good to me, but someone else must approve

    class.tx_install.php:2271

    $memory_limit_value is an integer. Compare with === -1 please.

    class.tx_install.php:2296

    Isn't this case very similar to the -1 case?
  2. Markus Klein commented on patch set 1 1 comment 01/26/12, 15:16

    No score
  3. Stefan Neufeind commented on patch set 2 01/26/12, 15:16

    Looks good to me, but someone else must approve And you might also want to review: http://review.typo3.org/7040
  4. Markus Klein uploaded patch set 2 01/26/12, 15:16

  5. Ernesto Baschny commented on patch set 3 V 0 01/26/12, 15:16

    by team member; Looks good to me, approved
  6. Markus Klein uploaded patch set 3 01/26/12, 15:16

  7. Markus Klein commented on patch set 3 01/26/12, 15:16

    Rebase and Commit message fix.
  8. Sebastian Fischer commented on patch set 2 01/26/12, 15:16

    Looks good to me, but someone else must approve
  9. Philipp Gampe commented on patch set 3 01/26/12, 15:16

    Verified; Looks good to me, but someone else must approve Works for me :)
  10. Mr. Jenkins commented on patch set 1 01/26/12, 15:16

  11. Mr. Jenkins commented on patch set 2 01/26/12, 15:16

  12. Mr. Jenkins commented on patch set 3 01/26/12, 15:16

  13. Wouter Wolters commented on patch set 3 01/26/12, 15:16

    Looks good to me, but someone else must approve
  14. Ernesto Baschny merged patch set 3 01/26/12, 15:16