70673[TASK] Download export file by PropagateResponseException in EXT:impexp
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1418
-
Alexander Nitsche uploaded patch set 1 08/17/21, 17:42
-
core-ci voted on patch set 1 V +1 08/17/21, 18:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15241
-
Alexander Nitsche updated the commit message in patch set 2 08/17/21, 18:06
-
core-ci voted on patch set 2 V +1 08/17/21, 18:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15242
-
Christian Kuhn commented on patch set 2 CR -1 08/23/21, 16:09
-
Christian Kuhn uploaded patch set 3 08/23/21, 16:48
-
Christian Kuhn commented on patch set 3 08/23/21, 16:51
ExportController.php:285Replyah, was only an issue in the test. -
core-ci voted on patch set 3 V +1 08/23/21, 17:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15423
-
Christian Kuhn voted on patch set 3 V +1 CR +1 08/23/21, 17:07
-
Christian Kuhn voted on patch set 3 CR 0 08/23/21, 17:07
-
Christian Kuhn voted on patch set 3 CR -1 08/23/21, 17:07
-
Christian Kuhn uploaded patch set 4 08/23/21, 17:08
-
Christian Kuhn voted on patch set 4 V +1 CR +1 08/23/21, 17:09
-
Anja Leichsenring commented on patch set 4 08/23/21, 17:23
can't we finally get rid of AccessibleMock usage, rather than creating new occurences? -
Christian Kuhn commented on patch set 4 08/23/21, 17:28
Reply
done here due to _call('getTableSelectOptions'); imho ok for now. -
core-ci voted on patch set 4 V +1 08/23/21, 17:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15427
-
Benni Mack voted on patch set 4 V +2 CR +2 08/23/21, 17:46
-
Benni Mack merged patch set 5 08/23/21, 17:46
ExportController.php:285