Review main Merged

70673[TASK] Download export file by PropagateResponseException in EXT:impexp

Alexander Nitsche CR +2 V +2 Normal +56 −13 updated 08/23/21, 17:46

Commit message

Since patch #94316, when downloading a file in the TYPO3 backend,
a PSR-7 response object should be created instead of using header()
and die().

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1418

  1. Alexander Nitsche uploaded patch set 1 08/17/21, 17:42

  2. core-ci voted on patch set 1 V +1 08/17/21, 18:00 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15241

  3. Alexander Nitsche updated the commit message in patch set 2 08/17/21, 18:06

  4. core-ci voted on patch set 2 V +1 08/17/21, 18:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15242

  5. Christian Kuhn commented on patch set 2 CR -1 08/23/21, 16:09

    ExportController.php:285

    unsure about responseFactory here, will probably update the patch.
  6. Christian Kuhn uploaded patch set 3 08/23/21, 16:48

  7. Christian Kuhn commented on patch set 3 08/23/21, 16:51

    ExportController.php:285 Reply

    ah, was only an issue in the test.
  8. core-ci voted on patch set 3 V +1 08/23/21, 17:01 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15423

  9. Christian Kuhn voted on patch set 3 V +1 CR +1 08/23/21, 17:07

  10. Christian Kuhn voted on patch set 3 CR 0 08/23/21, 17:07

  11. Christian Kuhn voted on patch set 3 CR -1 08/23/21, 17:07

  12. Christian Kuhn uploaded patch set 4 08/23/21, 17:08

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 08/23/21, 17:09

  14. Anja Leichsenring commented on patch set 4 08/23/21, 17:23

    can't we finally get rid of AccessibleMock usage, rather than creating new occurences?
  15. Christian Kuhn commented on patch set 4 08/23/21, 17:28

    Reply

    done here due to _call('getTableSelectOptions'); imho ok for now.
  16. core-ci voted on patch set 4 V +1 08/23/21, 17:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15427

  17. Benni Mack voted on patch set 4 V +2 CR +2 08/23/21, 17:46

  18. Benni Mack merged patch set 5 08/23/21, 17:46