Review main Merged

70674[BUGFIX] Do not transform text when RTE is disabled

Oli Bartsch CR +2 V +2 Normal +145 −15 updated 08/24/21, 10:43

Commit message

The TcaText data provider transforms a given database
field value with the RteHtmlParser as soon as `enableRichtext`
is set for the field in TCA. This means, the data provider
did previously not checked, whether RTE is disabled for the
user in general or for this specific field by configuration
(e.g. page TSconfig). This therefore led, among others, to
"normal" text being falsely wrapped with `<p>` tags.

This is now fixed by checking all relevant settings before
actually transforming the database field value.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Daniel Goerz +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1013

  1. Oli Bartsch uploaded patch set 1 08/17/21, 19:36

  2. core-ci voted on patch set 1 V -1 08/17/21, 19:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15243

  3. Oli Bartsch uploaded patch set 2 08/17/21, 19:52

  4. core-ci voted on patch set 2 V +1 08/17/21, 20:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15244

  5. Daniel Goerz voted on patch set 2 V +1 CR +1 08/23/21, 09:41

  6. Benni Mack commented on patch set 2 CR -1 08/23/21, 16:49

    please don't change the logic in DataHandler
  7. Oli Bartsch uploaded patch set 3 08/23/21, 18:03

  8. Oli Bartsch commented on patch set 3 08/23/21, 18:04

    Reply

    Thanks for your input. As discussed the DataHandler part is removed.
  9. core-ci voted on patch set 3 V +1 08/23/21, 18:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15437

  10. Benni Mack voted on patch set 3 V +1 CR +1 08/24/21, 07:32

  11. Daniel Goerz voted on patch set 3 V +1 CR +1 08/24/21, 08:56

  12. Oli Bartsch voted on patch set 3 V +2 CR +2 08/24/21, 10:42

  13. Oli Bartsch merged patch set 4 08/24/21, 10:43