Review main Merged

70675[TASK] Use multi record selection in scheduler module

Oli Bartsch CR +2 V +2 Hard +268 −208 updated 08/30/21, 06:53

Commit message

The multi record selection component, introduced in
allows to remove the custom checkbox logic next to
further improvements. For example, one can now
execute actions only for tasks of a specific task
group. This is possible since the multi record
selection component handles each task group as
a separate instance. This is achieved by applying
the "multi-record-selection-identifier" to each
task group container.

Besides, this patch does the following:

* Remove any dependency to EXT:recordlist
* Fix collapsing of task groups and toggling of icon
* Fix tablesort styling, applied to the header cols
* Remove unused span tags from the table listing
* Always execute tasks via POST

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 2135

Show 510 earlier messages
  1. Oli Bartsch uploaded patch set 1 08/17/21, 23:31

  2. core-ci voted on patch set 1 V -1 08/18/21, 00:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15246

  3. Oli Bartsch uploaded patch set 2 08/18/21, 10:35

  4. Oli Bartsch updated the commit message in patch set 3 08/18/21, 10:48

  5. core-ci voted on patch set 2 V +1 08/18/21, 10:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15260

  6. core-ci voted on patch set 3 V +1 08/18/21, 11:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15261

  7. Oli Bartsch updated the commit message in patch set 4 08/18/21, 13:55

  8. core-ci voted on patch set 4 V +1 08/18/21, 14:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15266

  9. Oli Bartsch uploaded patch set 5 08/18/21, 14:56

  10. core-ci voted on patch set 5 V +1 08/18/21, 15:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15271

  1. Oli Bartsch marked it work in progress 08/18/21, 16:32

  2. Jochen Roth voted on patch set 5 V +1 CR +1 08/18/21, 17:45

  3. Oli Bartsch uploaded patch set 6 08/19/21, 09:44

  4. core-ci voted on patch set 6 V +1 08/19/21, 09:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15300

  5. Oli Bartsch uploaded patch set 7 08/24/21, 12:44

  6. core-ci voted on patch set 7 V +1 08/24/21, 13:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15506

  7. Oli Bartsch uploaded patch set 8 08/27/21, 01:23

  8. core-ci voted on patch set 8 V -1 08/27/21, 01:39 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15696

  9. Oli Bartsch uploaded patch set 9 08/27/21, 14:23

  10. core-ci voted on patch set 9 V -1 08/27/21, 14:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15730

  11. Oli Bartsch uploaded patch set 10 08/27/21, 15:10

  12. core-ci voted on patch set 10 V -1 08/27/21, 15:29 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15734

  13. Oli Bartsch uploaded patch set 11 08/27/21, 15:55

  14. core-ci voted on patch set 11 V -1 08/27/21, 16:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15740

  15. Oli Bartsch uploaded patch set 12 08/27/21, 16:56

  16. Oli Bartsch commented on patch set 12 08/27/21, 16:58

    This change is ready for review.
    This depends on https://review.typo3.org/c/Packages/TYPO3.CMS/+/70799, which introduces the possibility to handle multiple instances per page. In this case "task groups". Testing can be done by adding the mentioned patch on top of this one.
  17. Oli Bartsch uploaded patch set 13 08/27/21, 17:12

  18. core-ci voted on patch set 12 V +1 08/27/21, 17:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15741

  19. core-ci voted on patch set 13 V +1 08/27/21, 17:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15742

  20. Oli Bartsch rebased onto patch set 14 08/28/21, 12:50

  21. Oli Bartsch commented on patch set 14 08/28/21, 12:53

    Rebased since https://review.typo3.org/c/Packages/TYPO3.CMS/+/70799 go merged. Can now be tested without any limitations.
  22. core-ci voted on patch set 14 V +1 08/28/21, 13:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15769

  23. Jochen Roth voted on patch set 14 V +1 CR +1 08/28/21, 13:48

  24. Benni Mack voted on patch set 14 V +2 CR +2 08/30/21, 06:53

  25. Benni Mack merged patch set 15 08/30/21, 06:53