Review main Merged

70676[BUGFIX] Fix backtracking error in UrlSoftReferenceParser

Nikita Hovratov CR +2 V +2 Easy +12 −1 updated 08/19/21, 06:30

Commit message

In case the URL is at the very end of a string and there are no space
characters that follow, the preg_split has failed with a backtracking
error. By declaring the last capturing group as optional, this error is
fixed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • Daniel Siepmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Nikita Hovratov uploaded patch set 1 08/18/21, 09:44

  2. Frank Nägler voted on patch set 1 CR +1 08/18/21, 10:00

  3. Frank Nägler voted on patch set 1 V +1 08/18/21, 10:01

  4. Frank Nägler commented on patch set 1 08/18/21, 10:02

    Thx for the quick fix, works on my system.
  5. core-ci voted on patch set 1 V +1 08/18/21, 10:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15256

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 08/18/21, 12:34

  7. Andreas Kienast merged patch set 2 08/18/21, 12:34

  8. Daniel Siepmann voted on patch set 2 V +1 08/19/21, 06:30